[FAB-10049] Change context to pointer

It is more idiomatic in golang to use a pointer instance to pass around
a collection of runtime information.

This change set changes the context to be initialized as a pointer

Change-Id: I146df8918321578c10ed158109a3d031fbc2d516
Signed-off-by: yacovm <yacovm@il.ibm.com>

Author: yacovm

core/committer/txvalidator/plugin_validator.go

@@ -89,7 +89,7 @@ func NewPluginValidator(pm PluginMapper, qec QueryExecutorCreator, deserializer
 	}
 }
 
-func (pv *PluginValidator) ValidateWithPlugin(ctx Context) error {
+func (pv *PluginValidator) ValidateWithPlugin(ctx *Context) error {
 	plugin, err := pv.getOrCreatePlugin(ctx)
 	if err != nil {
 		return &validation.ExecutionFailureError{
@@ -105,7 +105,7 @@ func (pv *PluginValidator) ValidateWithPlugin(ctx Context) error {
 	return err
 }
 
-func (pv *PluginValidator) getOrCreatePlugin(ctx Context) (validation.Plugin, error) {
+func (pv *PluginValidator) getOrCreatePlugin(ctx *Context) (validation.Plugin, error) {
 	pluginFactory := pv.PluginFactoryByName(PluginName(ctx.VSCCName))
 	if pluginFactory == nil {
 		return nil, errors.Errorf("plugin with name %s wasn't found", ctx.VSCCName)

core/committer/txvalidator/plugin_validator_test.go

@@ -30,7 +30,7 @@ func TestValidateWithPlugin(t *testing.T) {
 	deserializer := &mocks.IdentityDeserializer{}
 	capabilites := &mocks.Capabilities{}
 	v := txvalidator.NewPluginValidator(pm, qec, deserializer, capabilites)
-	ctx := txvalidator.Context{
+	ctx := &txvalidator.Context{
 		Namespace: "mycc",
 		VSCCName:  "vscc",
 	}
@@ -99,7 +99,7 @@ func TestSamplePlugin(t *testing.T) {
 
 	v := txvalidator.NewPluginValidator(pm, qec, deserializer, capabilites)
 	acceptAllPolicyBytes, _ := proto.Marshal(cauthdsl.AcceptAllPolicy)
-	ctx := txvalidator.Context{
+	ctx := &txvalidator.Context{
 		Namespace: "mycc",
 		VSCCName:  "vscc",
 		Policy:    acceptAllPolicyBytes,

core/committer/txvalidator/vscc_validator.go

@@ -193,7 +193,7 @@ func (v *VsccValidatorImpl) VSCCValidateTx(seq int, payload *common.Payload, env
 			}
 
 			// do VSCC validation
-			ctx := Context{
+			ctx := &Context{
 				Seq:       seq,
 				Envelope:  envBytes,
 				Block:     block,
@@ -234,7 +234,7 @@ func (v *VsccValidatorImpl) VSCCValidateTx(seq int, payload *common.Payload, env
 		// currently, VSCC does custom validation for LSCC only; if an hlf
 		// user creates a new system chaincode which is invokable from the outside
 		// they have to modify VSCC to provide appropriate validation
-		ctx := Context{
+		ctx := &Context{
 			Seq:       seq,
 			Envelope:  envBytes,
 			Block:     block,
@@ -257,7 +257,7 @@ func (v *VsccValidatorImpl) VSCCValidateTx(seq int, payload *common.Payload, env
 	return nil, peer.TxValidationCode_VALID
 }
 
-func (v *VsccValidatorImpl) VSCCValidateTxForCC(ctx Context) error {
+func (v *VsccValidatorImpl) VSCCValidateTxForCC(ctx *Context) error {
 	logger.Info("Validating", ctx, "with plugin")
 	err := v.pluginValidator.ValidateWithPlugin(ctx)
 	if err == nil {