[FAB-7612] MSPPrincipal for anonymity

This change-set does the following:
- It introduced a new method to learn if an identity is
anonymous.
- It provides an implementation for x509-based identities.
- It introduces a new MSP principal classification
to reason about anonymity of an identity

Change-Id: I3fa53fa59cd0090813acaadfa4bf9674f974638e
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Mathias Bjoerkqvist <mbj@zurich.ibm.com>

Author: adecaro

common/cauthdsl/cauthdsl_test.go

@@ -30,6 +30,10 @@ type mockIdentity struct {
 	idBytes []byte
 }
 
+func (id *mockIdentity) Anonymous() bool {
+	panic("implement me")
+}
+
 func (id *mockIdentity) ExpiresAt() time.Time {
 	return time.Time{}
 }

common/mocks/msp/noopmsp.go

@@ -102,6 +102,10 @@ func newNoopIdentity() (m.Identity, error) {
 	return &noopidentity{}, nil
 }
 
+func (id *noopidentity) Anonymous() bool {
+	panic("implement me")
+}
+
 func (id *noopidentity) SatisfiesPrincipal(*msp.MSPPrincipal) error {
 	return nil
 }

core/common/privdata/simplecollection_test.go

@@ -33,6 +33,10 @@ type mockIdentity struct {
 	idBytes []byte
 }
 
+func (id *mockIdentity) Anonymous() bool {
+	panic("implement me")
+}
+
 func (id *mockIdentity) ExpiresAt() time.Time {
 	return time.Time{}
 }

core/policy/mocks/mocks.go

@@ -87,6 +87,10 @@ type MockIdentity struct {
 	msg      []byte
 }
 
+func (id *MockIdentity) Anonymous() bool {
+	panic("implement me")
+}
+
 func (id *MockIdentity) SatisfiesPrincipal(p *mspproto.MSPPrincipal) error {
 	fmt.Printf("[SatisfiesPrincipal] id : [%s], [%s]\n", string(id.identity), string(p.Principal))
 	if !bytes.Equal(id.identity, p.Principal) {

discovery/support/mocks/identity.go

@@ -408,6 +408,10 @@ type idemixidentity struct {
 	associationProof *idemix.Signature
 }
 
+func (id *idemixidentity) Anonymous() bool {
+	return false
+}
+
 func newIdemixIdentity(msp *idemixmsp, nym *FP256BN.ECP, role *m.MSPRole, ou *m.OrganizationUnit, proof *idemix.Signature) *idemixidentity {
 	id := &idemixidentity{}
 	id.Nym = nym

msp/idemixmsp.go

@@ -128,6 +128,10 @@ func (id *identity) GetOrganizationalUnits() []*OUIdentifier {
 	return res
 }
 
+func (id *identity) Anonymous() bool {
+	return false
+}
+
 // NewSerializedIdentity returns a serialized identity
 // having as content the passed mspID and x509 certificate in PEM format.
 // This method does not check the validity of certificate nor

msp/identities.go

@@ -83,6 +83,10 @@ type MockIdentity struct {
 	ID string
 }
 
+func (m *MockIdentity) Anonymous() bool {
+	panic("implement me")
+}
+
 func (m *MockIdentity) ExpiresAt() time.Time {
 	panic("implement me")
 }

msp/mocks/mocks.go

@@ -150,6 +150,9 @@ type Identity interface {
 	//       signer's identity
 	GetOrganizationalUnits() []*OUIdentifier
 
+	// Anonymous returns true if this is an anonymous identity, false otherwise
+	Anonymous() bool
+
 	// Verify a signature over some message using this identity as reference
 	Verify(msg []byte, sig []byte) error
 

msp/msp.go

@@ -418,6 +418,7 @@ func TestIdentitiesGetters(t *testing.T) {
 	assert.NotNil(t, idid)
 	mspid := id.GetMSPIdentifier()
 	assert.NotNil(t, mspid)
+	assert.False(t, id.Anonymous())
 }
 
 func TestSignAndVerify(t *testing.T) {

msp/msp_test.go

@@ -134,6 +134,10 @@ type Identity struct {
 	Msg            []byte
 }
 
+func (id *Identity) Anonymous() bool {
+	panic("implement me")
+}
+
 func (id *Identity) ExpiresAt() time.Time {
 	return id.expirationDate
 }