[FAB-9765] Introduce CollectionUpgrade Capability

Instead of using V1_2Validation capability at lscc to
check whether collection upgrades are allowed,
this CR introduces CollectionUpgrade capability which will be
used with lscc

Change-Id: I4559c31beeb9e1a0676bcb19a882d7bb972e6b33
Signed-off-by: senthil <cendhu@gmail.com>

Author: cendhu

common/capabilities/application.go

@@ -75,6 +75,12 @@ func (ap *ApplicationProvider) PrivateChannelData() bool {
 	return ap.v11PvtDataExperimental
 }
 
+// CollectionUpgrade returns true if this channel is configured to allow updates to
+// existing collection or add new collections through chaincode upgrade (as introduced in v1.2)
+func (ap ApplicationProvider) CollectionUpgrade() bool {
+	return ap.v12
+}
+
 // V1_1Validation returns true is this channel is configured to perform stricter validation
 // of transactions (as introduced in v1.1).
 func (ap *ApplicationProvider) V1_1Validation() bool {

common/capabilities/application_test.go

@@ -46,6 +46,13 @@ func TestApplicationPvtDataExperimental(t *testing.T) {
 	assert.True(t, op.PrivateChannelData())
 }
 
+func TestApplicationCollectionUpgrade(t *testing.T) {
+	op := NewApplicationProvider(map[string]*cb.Capability{
+		ApplicationV1_2: {},
+	})
+	assert.True(t, op.CollectionUpgrade())
+}
+
 func TestChaincodeLifecycleExperimental(t *testing.T) {
 	op := NewApplicationProvider(map[string]*cb.Capability{
 		ApplicationChaincodeLifecycleExperimental: {},

common/channelconfig/api.go

@@ -129,6 +129,10 @@ type ApplicationCapabilities interface {
 	// PrivateChannelData returns true if support for private channel data (a.k.a. collections) is enabled.
 	PrivateChannelData() bool
 
+	// CollectionUpgrade returns true if this channel is configured to allow updates to
+	// existing collection or add new collections through chaincode upgrade (as introduced in v1.2)
+	CollectionUpgrade() bool
+
 	// V1_1Validation returns true is this channel is configured to perform stricter validation
 	// of transactions (as introduced in v1.1).
 	V1_1Validation() bool

common/mocks/config/application.go

@@ -40,6 +40,7 @@ type MockApplicationCapabilities struct {
 	ForbidDuplicateTXIdInBlockRv bool
 	ResourcesTreeRv              bool
 	PrivateChannelDataRv         bool
+	CollectionUpgradeRv          bool
 	V1_1ValidationRv             bool
 	V1_2ValidationRv             bool
 	MetadataLifecycleRv          bool
@@ -62,6 +63,10 @@ func (mac *MockApplicationCapabilities) PrivateChannelData() bool {
 	return mac.PrivateChannelDataRv
 }
 
+func (mac *MockApplicationCapabilities) CollectionUpgrade() bool {
+	return mac.CollectionUpgradeRv
+}
+
 func (mac *MockApplicationCapabilities) V1_1Validation() bool {
 	return mac.V1_1ValidationRv
 }