[FAB-7523] Improve bccsp error message

Keith Smith · Keith Smith · commit a26ed3d173fd · 2017-12-20T10:27:16.000-05:00
The current error message prints as

Unsupported 'SignKey' provided [&amp;[&lt;binary data]]

Change it to display similar to:

Unsupported 'SignKey' provided [*ecdsaPublicKey]

Change-Id: I6b2004cf24c30a245df7f360a533933303de486e
Signed-off-by: Keith Smith &lt;bksmith@us.ibm.com&gt;
diff --git a/bccsp/sw/impl.go b/bccsp/sw/impl.go
@@ -316,9 +316,10 @@ func (csp *impl) Sign(k bccsp.Key, digest []byte, opts bccsp.SignerOpts) (signat
 		return nil, errors.New("Invalid digest. Cannot be empty.")
 	}
 
-	signer, found := csp.signers[reflect.TypeOf(k)]
+	keyType := reflect.TypeOf(k)
+	signer, found := csp.signers[keyType]
 	if !found {
-		return nil, errors.Errorf("Unsupported 'SignKey' provided [%v]", k)
+		return nil, errors.Errorf("Unsupported 'SignKey' provided [%s]", keyType)
 	}
 
 	signature, err = signer.Sign(k, digest, opts)

Original file line number	Diff line number	Diff line change
`@@ -316,9 +316,10 @@ func (csp *impl) Sign(k bccsp.Key, digest []byte, opts bccsp.SignerOpts) (signat`
`316`	`316`	`return nil, errors.New("Invalid digest. Cannot be empty.")`
`317`	`317`	`}`
`318`	`318`
`319`		`- signer, found := csp.signers[reflect.TypeOf(k)]`
	`319`	`+ keyType := reflect.TypeOf(k)`
	`320`	`+ signer, found := csp.signers[keyType]`
`320`	`321`	`if !found {`
`321`		`- return nil, errors.Errorf("Unsupported 'SignKey' provided [%v]", k)`
	`322`	`+ return nil, errors.Errorf("Unsupported 'SignKey' provided [%s]", keyType)`
`322`	`323`	`}`
`323`	`324`
`324`	`325`	`signature, err = signer.Sign(k, digest, opts)`