[FAB-9003] Add chaincode lifecycle capability

Although chaincode lifecycle is projected to be part of Fabric v1.2, for
development purposes, tying it to the V1_2 capability upfront is not an
option, as until everything is in place, we need to keep the code path
disabled.  Therefore, this CR defines a new capability for chaincode
lifecycle which may be turned on separately.  It is marked as
experimental in the spirit of being able to cut a release at any point.
However, the expectation is that this capability will disappear and the
chaincode lifecycle will be enabled through the v1.2 capability.

Change-Id: I61cdd106c907b4676d35eb1f288f69e578c83aad
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

Author: Jason Yellick

common/capabilities/application.go

@@ -24,6 +24,12 @@ const (
 
 	// ApplicationResourcesTreeExperimental is the capabilties string for private data using the experimental feature of collections/sideDB.
 	ApplicationResourcesTreeExperimental = "V1_1_RESOURCETREE_EXPERIMENTAL"
+
+	// ApplicationChaincodeLifecycleExperimental is the capabilties string for improved chaincode lifecycle
+	// which is targetted to be a real feature for v1.2, but which is being included only as experimental
+	// during development.  This string will hopefully be removed prior to the release of v1.2 and
+	// Will be enabled along with ApplicationV1_2
+	ApplicationChaincodeLifecycleExperimental = "V1_2_CHAINCODE_LIFECYCLE_EXPERIMENTAL"
 )
 
 // ApplicationProvider provides capabilities information for application level config.
@@ -33,6 +39,7 @@ type ApplicationProvider struct {
 	v12                          bool
 	v11PvtDataExperimental       bool
 	v11ResourcesTreeExperimental bool
+	v12LifecycleExperimental     bool
 }
 
 // NewApplicationProvider creates a application capabilities provider.
@@ -43,6 +50,7 @@ func NewApplicationProvider(capabilities map[string]*cb.Capability) *Application
 	_, ap.v12 = capabilities[ApplicationV1_2]
 	_, ap.v11PvtDataExperimental = capabilities[ApplicationPvtDataExperimental]
 	_, ap.v11ResourcesTreeExperimental = capabilities[ApplicationResourcesTreeExperimental]
+	_, ap.v12LifecycleExperimental = capabilities[ApplicationChaincodeLifecycleExperimental]
 	return ap
 }
 
@@ -72,3 +80,10 @@ func (ap *ApplicationProvider) PrivateChannelData() bool {
 func (ap *ApplicationProvider) V1_1Validation() bool {
 	return ap.v11 || ap.v12
 }
+
+// MetadataLifecycle indicates whether the peer should use the deprecated and problematic
+// v1.0/v1.1 lifecycle, or whether it should use the newer per channel peer local chaincode
+// metadata package approach planned for release with Fabric v1.2
+func (ap *ApplicationProvider) MetadataLifecycle() bool {
+	return ap.v12LifecycleExperimental
+}

common/capabilities/application_experimental.go

@@ -20,6 +20,8 @@ func (ap *ApplicationProvider) HasCapability(capability string) bool {
 		return true
 	case ApplicationResourcesTreeExperimental:
 		return true
+	case ApplicationChaincodeLifecycleExperimental:
+		return true
 	default:
 		return false
 	}

common/capabilities/application_test.go

@@ -43,3 +43,10 @@ func TestApplicationPvtDataExperimental(t *testing.T) {
 	})
 	assert.True(t, op.PrivateChannelData())
 }
+
+func TestChaincodeLifecycleExperimental(t *testing.T) {
+	op := NewApplicationProvider(map[string]*cb.Capability{
+		ApplicationChaincodeLifecycleExperimental: {},
+	})
+	assert.True(t, op.MetadataLifecycle())
+}

common/channelconfig/api.go

@@ -129,6 +129,11 @@ type ApplicationCapabilities interface {
 	// V1_1Validation returns true is this channel is configured to perform stricter validation
 	// of transactions (as introduced in v1.1).
 	V1_1Validation() bool
+
+	// MetadataLifecycle indicates whether the peer should use the deprecated and problematic
+	// v1.0/v1.1 lifecycle, or whether it should use the newer per channel peer local chaincode
+	// metadata package approach planned for release with Fabric v1.2
+	MetadataLifecycle() bool
 }
 
 // OrdererCapabilities defines the capabilities for the orderer portion of a channel

common/mocks/config/application.go

@@ -26,6 +26,7 @@ type MockApplicationCapabilities struct {
 	ResourcesTreeRv              bool
 	PrivateChannelDataRv         bool
 	V1_1ValidationRv             bool
+	MetadataLifecycleRv          bool
 }
 
 func (mac *MockApplicationCapabilities) Supported() error {
@@ -47,3 +48,7 @@ func (mac *MockApplicationCapabilities) PrivateChannelData() bool {
 func (mac *MockApplicationCapabilities) V1_1Validation() bool {
 	return mac.V1_1ValidationRv
 }
+
+func (mac *MockApplicationCapabilities) MetadataLifecycle() bool {
+	return mac.MetadataLifecycleRv
+}

sampleconfig/configtx.yaml

@@ -332,3 +332,9 @@ Capabilities:
         # NOTE: Use of this feature with non "experimental" binaries on
         # the network may cause a fork.
         V1_1_RESOURCETREE_EXPERIMENTAL: false
+        # V1_2_CHAINCODE_LIFECYCLE_EXPERIMENTAL is an Application capability
+        # to enable the new lifecycle semantics of "Install Code, Install 
+        # Metadata to a Channel, Define Chaincode, Init Chaincode"
+        # This is an in development feature and is useful only for developer
+        # testing at this time.
+        V1_2_CHAINCODE_LIFECYCLE_EXPERIMENTAL: false