Skip to content

Commit fb53715

Browse files
author
Jason Yellick
committedJan 18, 2018
[FAB-7808] Fix inconsistent configtx.yaml
The sample and example configtx.yaml file have profiles with similar names, but slightly different content. As this is a sample, it should be fixed to read consistently. This ensures that the capabilities section for the channel is always specified along with the one for capabilities in the orderer. It also renames the alias "GlobalCapabilities" to "ChannelCapabilities" as this is how the doc refers to them. Change-Id: I407918c604de1ee546d101edccdcb32693cdf043 Signed-off-by: Jason Yellick <jyellick@us.ibm.com>
1 parent 29863eb commit fb53715

File tree

2 files changed

+31
-10
lines changed

2 files changed

+31
-10
lines changed
 

‎examples/e2e_cli/configtx.yaml

+3-5
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Profiles:
1616

1717
TwoOrgsOrdererGenesis:
1818
Capabilities:
19-
<<: *GlobalCapabilities
19+
<<: *ChannelCapabilities
2020
Orderer:
2121
<<: *OrdererDefaults
2222
Organizations:
@@ -37,8 +37,6 @@ Profiles:
3737
- *Org2
3838
Capabilities:
3939
<<: *ApplicationCapabilities
40-
Resources:
41-
DefaultModPolicy: /Channel/Application/Writers
4240

4341
################################################################################
4442
#
@@ -179,9 +177,9 @@ Application: &ApplicationDefaults
179177
#
180178
################################################################################
181179
Capabilities:
182-
# Global capabilities apply to both the orderers and the peers and must be
180+
# Channel capabilities apply to both the orderers and the peers and must be
183181
# supported by both. Set the value of the capability to true to require it.
184-
Global: &GlobalCapabilities
182+
Global: &ChannelCapabilities
185183
# V1.1 for Global is a catchall flag for behavior which has been
186184
# determined to be desired for all orderers and peers running v1.0.x,
187185
# but the modification of which would cause imcompatibilities. Users

‎sampleconfig/configtx.yaml

+28-5
Original file line numberDiff line numberDiff line change
@@ -63,13 +63,22 @@ Profiles:
6363
# but additionally defines the v1.1 only capabilities which do
6464
# not allow a mixed v1.0.x v1.1.x network
6565
SampleDevModeSoloV1_1:
66+
Capabilities:
67+
<<: *ChannelCapabilities
6668
Orderer:
6769
<<: *OrdererDefaults
6870
Organizations:
6971
- <<: *SampleOrg
7072
AdminPrincipal: Role.MEMBER
7173
Capabilities:
7274
<<: *OrdererCapabilities
75+
Application:
76+
<<: *ApplicationDefaults
77+
Organizations:
78+
- <<: *SampleOrg
79+
AdminPrincipal: Role.MEMBER
80+
Capabilities:
81+
<<: *ApplicationCapabilities
7382
Consortiums:
7483
SampleConsortium:
7584
Organizations:
@@ -85,6 +94,11 @@ Profiles:
8594
Organizations:
8695
- <<: *SampleOrg
8796
AdminPrincipal: Role.MEMBER
97+
Application:
98+
<<: *ApplicationDefaults
99+
Organizations:
100+
- <<: *SampleOrg
101+
AdminPrincipal: Role.MEMBER
88102
Consortiums:
89103
SampleConsortium:
90104
Organizations:
@@ -95,6 +109,8 @@ Profiles:
95109
# but additionally defines the v1.1 only capabilities which do
96110
# not allow a mixed v1.0.x v1.1.x network
97111
SampleDevModeKafkaV1_1:
112+
Capabilities:
113+
<<: *ChannelCapabilities
98114
Orderer:
99115
<<: *OrdererDefaults
100116
OrdererType: kafka
@@ -103,6 +119,13 @@ Profiles:
103119
AdminPrincipal: Role.MEMBER
104120
Capabilities:
105121
<<: *OrdererCapabilities
122+
Application:
123+
<<: *ApplicationDefaults
124+
Organizations:
125+
- <<: *SampleOrg
126+
AdminPrincipal: Role.MEMBER
127+
Capabilities:
128+
<<: *ApplicationCapabilities
106129
Consortiums:
107130
SampleConsortium:
108131
Organizations:
@@ -140,7 +163,7 @@ Profiles:
140163
# mixed v1.0.x v1.1.x network.
141164
SampleSingleMSPSoloV1_1:
142165
Capabilities:
143-
<<: *GlobalCapabilities
166+
<<: *ChannelCapabilities
144167
Orderer:
145168
<<: *OrdererDefaults
146169
Organizations:
@@ -156,7 +179,7 @@ Profiles:
156179
# SampleSingleMSPSoloV1_1 one only in that it uses the Kafka-based orderer.
157180
SampleSingleMSPKafkaV1_1:
158181
Capabilities:
159-
<<: *GlobalCapabilities
182+
<<: *ChannelCapabilities
160183
Orderer:
161184
<<: *OrdererDefaults
162185
OrdererType: kafka
@@ -328,10 +351,10 @@ Application: &ApplicationDefaults
328351
#
329352
################################################################################
330353
Capabilities:
331-
# Global capabilities apply to both the orderers and the peers and must be
354+
# Channel capabilities apply to both the orderers and the peers and must be
332355
# supported by both. Set the value of the capability to true to require it.
333-
Global: &GlobalCapabilities
334-
# V1.1 for Global is a catchall flag for behavior which has been
356+
Channel: &ChannelCapabilities
357+
# V1.1 for Channel is a catchall flag for behavior which has been
335358
# determined to be desired for all orderers and peers running v1.0.x,
336359
# but the modification of which would cause imcompatibilities. Users
337360
# should leave this flag set to true.

0 commit comments

Comments
 (0)
Please sign in to comment.