What exactly does fzf.vim change?

[kaddkaka]

Coming from fzf-vim the tip is:

lua require('fzf-lua').setup({'fzf-vim'})

It is a bit unclear what this actually does. My guess:

1. It changes some options of FzfLua
2. It shadows some commands from fzf.vim

My aim was to compare and evaluate FzfLua to fzf.vim but 2point 2 surprised me.

[ibhagwan]

You’re correct, it creates fzf.vim’s commands :Files, etc. and tries to mimic its default settings.

Overall all profiles are just a bunch of setup options, see:
https://github.com/ibhagwan/fzf-lua/blob/main/lua/fzf-lua/profiles/fzf-vim.lua

[ibhagwan]

:FzfLua files cwd=expand("%:h") doesn't seem to evaluate expand, I get this message back from FzfLua:

[Fzf-lua] Unable to access 'expand("%:h")', removing 'cwd' option.

You can run :lua FzfLua.files({ cwd = vim.fn.expand("%:h") })

[kaddkaka]

The surprising patch change only happens with :FzfLua files cwd="%:H".

Using :lua FzfLua.files({ cwd = vim.fn.expand("%:h") }) the picker path is not changed when doing alt-h or alt-i.

[ibhagwan]

The surprising patch change only happens with :FzfLua files cwd="%:H"

Because you’re adding quotes the argument is passed as a string by the lua conversion library used by the FzfLua command parser, I’ll have to check but it probably gets expanded by config.normalize_opts.

Using :lua FzfLua.files({ cwd = vim.fn.expand("%:h") }) the picker path is not changed when doing alt-h or alt-i.

Do you mean cwd isn’t preserved between toggles?

[ibhagwan]

So I tested what happens:

1. :lua FzfLua.files({ cwd = vim.fn.expand("%:h") }) - works perfectly as expected, cwd is preserved between toggles
2. FzfLua files cwd=%:h - works on the first call, cwd is saved in call options as %:h and gets expanded again on a toggle therefor the current term is being substituted with % and cwd isn’t preserved, I’m not an expert on vimscript but if you find a way to call the expand during argument expansion it will work

I don’t see (2) as a bug, since you’re setting cwd to a literal %:h, fzf-lua simply does what it should and expands it as part of normalize_opts (but doesn’t overwrite your supplied cwd), if you want a fixed cwd make sure it gets expanded before.

[kaddkaka]

This is a sound explanation, thank you 👍

Now that I know what's happening I'll relax and change to use the lua syntax.