Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking zoom buttons interrupts slideshow playback #331

Closed
hdz521sxx opened this issue Feb 23, 2025 · 4 comments
Closed

Clicking zoom buttons interrupts slideshow playback #331

hdz521sxx opened this issue Feb 23, 2025 · 4 comments
Labels
bug Something isn't working released Implemented and released

Comments

@hdz521sxx
Copy link

Describe the bug

当我打开照片预览时,我点击轮博图按钮,开始轮博,到某一张图时,我点击放大按钮,可以正常轮博,

然后等轮博到下一张时,继续点击放大按钮,轮博图就卡住了,并且按钮状态没有及时更新,在移动端,h5情况下,点击开始轮博的按钮,开始轮博后,点击放大图片按钮,轮博效果就直接卡住了
总结,轮博开始后,点击点击放大按钮会终止轮博,并且对应轮博按钮的状态没有及时更新

Expected behavior

两种办法
1、轮博图开始时,可以禁用放大和缩小按钮
2、轮博开始后,点击放大和缩小按钮,不会中断轮博图的播放
3、轮博开始后,可以点击放大和缩小按钮,点击之后,轮博正常终止,轮博图按钮的状态正常更新即可

How to reproduce

https://react-photo-album.com/examples/lightbox

在移动端的情况下使用

Screenshots / Logs

No response

Additional context

No response

@igordanchenko
Copy link
Owner

Please translate to English.

@hdz521sxx
Copy link
Author

When I open the photo preview, I click the wheel map button to start the wheel, when I reach a certain image, I click the enlarge button, I can normal wheel blog,

Then, when the wheel bo goes to the next one, continue to click the enlarge button, and the wheel Bo map will be stuck, and the status of the button is not updated in time. In the case of mobile terminal, h5, click the button to start the wheel Bo, and after the wheel Bo starts, click the button to enlarge the picture, and the wheel Bo effect will be stuck directly

In summary, after the wheel starts, clicking the zoom button will terminate the wheel, and the status of the corresponding wheel button is not updated in time

Expected behavior

Two ways

  1. Zoom in and zoom out buttons can be disabled at the beginning of Robotu

2, after the start of the wheel, click the zoom and zoom button, will not interrupt the playback of the wheel

  1. After the wheel starts, you can click the zoom and zoom buttons. After clicking, the wheel stops normally, and the status of the wheel map button can be updated normally

@igordanchenko
Copy link
Owner

Thank you. I was able to obtain the following translation with Google Translate.

Describe the bug

When I open the photo preview, I click the carousel button to start the carousel. When I reach a certain picture, I click the zoom button and the carousel can be played normally.

Then when the carousel reaches the next picture, I continue to click the zoom button, and the carousel is stuck, and the button status is not updated in time. On the mobile terminal, in the case of h5, click the button to start the carousel, and after the carousel starts, click the zoom button, and the carousel effect is directly stuck.

In summary, after the carousel starts, clicking the zoom button will terminate the carousel, and the status of the corresponding carousel button is not updated in time.

Expected behavior

Two methods

  1. When the carousel starts, you can disable the zoom in and zoom out buttons
  2. After the carousel starts, clicking the zoom in and zoom out buttons will not interrupt the playback of the carousel
  3. After the carousel starts, you can click the zoom in and zoom out buttons. After clicking, the carousel ends normally, and the status of the carousel buttons is updated normally.

I'll publish a fix implementing approach #2 - clicking zoom in / zoom out buttons should not interrupt slideshow playback.

@igordanchenko igordanchenko changed the title LightBox bug Clicking zoom buttons interrupts slideshow playback Mar 12, 2025
Copy link

🎉 This issue has been resolved in version 3.21.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Implemented and released label Mar 12, 2025
@igordanchenko igordanchenko added the bug Something isn't working label Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Implemented and released
Projects
None yet
Development

No branches or pull requests

2 participants