Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateCanConfig time channel naming #123

Open
lawsonampere opened this issue Mar 11, 2025 · 1 comment
Open

CreateCanConfig time channel naming #123

lawsonampere opened this issue Mar 11, 2025 · 1 comment
Assignees

Comments

@lawsonampere
Copy link

While applying DBC files using the dbclib repo, the DBC viewer produces an error about the time channel.

I'm not sure if the DBC viewer or the the mdflib is the actual issue, but since you have created both libraries I figured you may know better where a change is needed. Otherwise putting this here as it is an easy modification to make to the mdflib for those who need it. I simply changed the time channel created by the CreateCanConfig() function to be "Timestamp" instead of "t".

Modification of mdfwriter.cpp lines 603, 623, 632, and 650. Confirmed after this change that the DBC viewer can decode the file now.

Image

Errors from DBC File Viewer with "t" time channel.
Image

Image

@ihedvall ihedvall self-assigned this Mar 12, 2025
@ihedvall
Copy link
Owner

@lawsonampere
This is probably a bug in the DBC Viewer that assumes that the time channel name must be Timestamp. CSS log files uses Timestamp while Vector log files uses t. The correct way of finding a time channel within the group is to searching for the channel marked as Master and with synchronization type equal to Time.

I correct the bug in the DBC Viewer application. Note that there is an on-going change for CAN configuration that involves the SI blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants