Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit Cargo.lock? #439

Closed
iliekturtles opened this issue Aug 31, 2023 · 1 comment · Fixed by #456
Closed

Commit Cargo.lock? #439

iliekturtles opened this issue Aug 31, 2023 · 1 comment · Fixed by #456

Comments

@iliekturtles
Copy link
Owner

https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html

@hellow554
Copy link
Contributor

@iliekturtles this would prevent the current situation, where CI fails for reasons outside of the PRs matters because of an depdency update.

I would advocate for this and updated #456 accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants