Skip to content

Commit ceacebe

Browse files
committed
chore: rename InvocableScripts to InvokableScripts
for more info see influxdata/openapi#317
1 parent f50edf0 commit ceacebe

File tree

11 files changed

+44
-44
lines changed

11 files changed

+44
-44
lines changed

CHANGELOG.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ This release also uses new version of InfluxDB OSS API definitions - [oss.yml](h
6868
### Features
6969
1. [#324](https://github.com/influxdata/influxdb-client-java/pull/298) Removed dependency on `io.swagger:swagger-annotations` and updated swagger to the latest version
7070
1. [#289](https://github.com/influxdata/influxdb-client-java/pull/298): Upgrade `RxJava2` -> `RxJava3`, update outdated dependencies
71-
1. [#316](https://github.com/influxdata/influxdb-client-java/pull/316): Add `InvocableScriptsApi` to create, update, list, delete and invoke scripts by seamless way
71+
1. [#316](https://github.com/influxdata/influxdb-client-java/pull/316): Add `InvokableScriptsApi` to create, update, list, delete and invoke scripts by seamless way
7272
1. [#315](https://github.com/influxdata/influxdb-client-java/pull/315): Add support for timezones [FluxDSL]
7373
1. [#317](https://github.com/influxdata/influxdb-client-java/pull/317): Gets HTTP headers from the unsuccessful HTTP request
7474
1. [#334](https://github.com/influxdata/influxdb-client-java/pull/334): Supports not operator [FluxDSL]

client-core/src/main/java/com/influxdb/query/internal/FluxCsvParser.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ private enum ParsingState {
7373
public enum ResponseMetadataMode {
7474
FULL,
7575

76-
// useful for Invocable scripts
76+
// useful for Invokable scripts
7777
ONLY_NAMES
7878
}
7979

client/src/generated/java/com/influxdb/client/service/InvocableScriptsService.java client/src/generated/java/com/influxdb/client/service/InvokableScriptsService.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
import java.util.List;
1919
import java.util.Map;
2020

21-
public interface InvocableScriptsService {
21+
public interface InvokableScriptsService {
2222
/**
2323
* Delete a script
2424
* Deletes a script and all associated records.
@@ -44,7 +44,7 @@ Call<Scripts> getScripts(
4444

4545
/**
4646
* Retrieve a script
47-
* Uses script ID to retrieve details of an invocable script.
47+
* Uses script ID to retrieve details of an invokable script.
4848
* @param scriptID The script ID. (required)
4949
* @return Call&lt;Script&gt;
5050
*/
@@ -55,7 +55,7 @@ Call<Script> getScriptsID(
5555

5656
/**
5757
* Update a script
58-
* Updates properties (&#x60;name&#x60;, &#x60;description&#x60;, and &#x60;script&#x60;) of an invocable script.
58+
* Updates properties (&#x60;name&#x60;, &#x60;description&#x60;, and &#x60;script&#x60;) of an invokable script.
5959
* @param scriptID The script ID. (required)
6060
* @param scriptUpdateRequest Script update to apply (required)
6161
* @return Call&lt;Script&gt;

client/src/main/java/com/influxdb/client/InfluxDBClient.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -245,12 +245,12 @@ public interface InfluxDBClient extends AutoCloseable {
245245
DeleteApi getDeleteApi();
246246

247247
/**
248-
* Create an InvocableScripts API instance.
248+
* Create an InvokableScripts API instance.
249249
*
250-
* @return InvocableScripts API instance
250+
* @return InvokableScripts API instance
251251
*/
252252
@Nonnull
253-
InvocableScriptsApi getInvocableScriptsApi();
253+
InvokableScriptsApi getInvokableScriptsApi();
254254

255255
/**
256256
* Create an implementation of the API endpoints defined by the {@code service} interface.

client/src/main/java/com/influxdb/client/InvocableScriptsApi.java client/src/main/java/com/influxdb/client/InvokableScriptsApi.java

+5-5
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
* @author Jakub Bednar (bednar@github) (03/21/2022 07:54)
4646
*/
4747
@ThreadSafe
48-
public interface InvocableScriptsApi {
48+
public interface InvokableScriptsApi {
4949

5050
/**
5151
* Create a script.
@@ -81,7 +81,7 @@ public interface InvocableScriptsApi {
8181
* @return scripts
8282
*/
8383
@Nonnull
84-
List<Script> findScripts(@Nonnull final InvocableScriptsQuery query);
84+
List<Script> findScripts(@Nonnull final InvokableScriptsQuery query);
8585

8686
/**
8787
* Delete a script.
@@ -94,7 +94,7 @@ public interface InvocableScriptsApi {
9494
* Executes the script and synchronously map whole response to {@code List<FluxTable>}.
9595
* <p>
9696
* NOTE: This method is not intended for large query results.
97-
* Use {@link InvocableScriptsApi#invokeScript(String, Map, BiConsumer, Consumer, Runnable)}
97+
* Use {@link InvokableScriptsApi#invokeScript(String, Map, BiConsumer, Consumer, Runnable)}
9898
* for large data streaming.
9999
*
100100
* @param scriptId The ID of the script to invoke. (required)
@@ -136,7 +136,7 @@ void invokeScript(@Nonnull final String scriptId,
136136
* Executes the script and synchronously map whole response to list of object with given type. <p>
137137
* <p>
138138
* NOTE: This method is not intended for large query results.
139-
* Use {@link InvocableScriptsApi#invokeScript(String, Map, Class, BiConsumer, Consumer, Runnable)}
139+
* Use {@link InvokableScriptsApi#invokeScript(String, Map, Class, BiConsumer, Consumer, Runnable)}
140140
* for large data streaming.
141141
*
142142
* @param scriptId The ID of the script to invoke. (required)
@@ -188,7 +188,7 @@ <M> void invokeScript(@Nonnull final String scriptId,
188188
* Executes the script and synchronously map whole response to {@link String} result.
189189
* <p>
190190
* NOTE: This method is not intended for large query results.
191-
* Use {@link InvocableScriptsApi#invokeScriptRaw(String, Map, BiConsumer, Consumer, Runnable)}
191+
* Use {@link InvokableScriptsApi#invokeScriptRaw(String, Map, BiConsumer, Consumer, Runnable)}
192192
* for large data streaming.
193193
*
194194
* @param scriptId The ID of the script to invoke. (required)

client/src/main/java/com/influxdb/client/InvocableScriptsQuery.java client/src/main/java/com/influxdb/client/InvokableScriptsQuery.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323

2424
import javax.annotation.Nullable;
2525

26-
public class InvocableScriptsQuery {
26+
public class InvokableScriptsQuery {
2727

2828
/**
2929
* Offset. (optional)

client/src/main/java/com/influxdb/client/internal/InfluxDBClientImpl.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
import com.influxdb.client.DeleteApi;
3535
import com.influxdb.client.InfluxDBClient;
3636
import com.influxdb.client.InfluxDBClientOptions;
37-
import com.influxdb.client.InvocableScriptsApi;
37+
import com.influxdb.client.InvokableScriptsApi;
3838
import com.influxdb.client.LabelsApi;
3939
import com.influxdb.client.NotificationEndpointsApi;
4040
import com.influxdb.client.NotificationRulesApi;
@@ -59,7 +59,7 @@
5959
import com.influxdb.client.service.ChecksService;
6060
import com.influxdb.client.service.DashboardsService;
6161
import com.influxdb.client.service.DeleteService;
62-
import com.influxdb.client.service.InvocableScriptsService;
62+
import com.influxdb.client.service.InvokableScriptsService;
6363
import com.influxdb.client.service.LabelsService;
6464
import com.influxdb.client.service.NotificationEndpointsService;
6565
import com.influxdb.client.service.NotificationRulesService;
@@ -244,8 +244,8 @@ public DeleteApi getDeleteApi() {
244244

245245
@NotNull
246246
@Override
247-
public InvocableScriptsApi getInvocableScriptsApi() {
248-
return new InvocableScriptsApiImpl(retrofit.create(InvocableScriptsService.class));
247+
public InvokableScriptsApi getInvokableScriptsApi() {
248+
return new InvokableScriptsApiImpl(retrofit.create(InvokableScriptsService.class));
249249
}
250250

251251
@Nonnull

client/src/main/java/com/influxdb/client/internal/InvocableScriptsApiImpl.java client/src/main/java/com/influxdb/client/internal/InvokableScriptsApiImpl.java

+8-8
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,14 @@
3030
import javax.annotation.Nullable;
3131

3232
import com.influxdb.Cancellable;
33-
import com.influxdb.client.InvocableScriptsApi;
34-
import com.influxdb.client.InvocableScriptsQuery;
33+
import com.influxdb.client.InvokableScriptsApi;
34+
import com.influxdb.client.InvokableScriptsQuery;
3535
import com.influxdb.client.domain.Script;
3636
import com.influxdb.client.domain.ScriptCreateRequest;
3737
import com.influxdb.client.domain.ScriptInvocationParams;
3838
import com.influxdb.client.domain.ScriptUpdateRequest;
3939
import com.influxdb.client.domain.Scripts;
40-
import com.influxdb.client.service.InvocableScriptsService;
40+
import com.influxdb.client.service.InvokableScriptsService;
4141
import com.influxdb.internal.AbstractQueryApi;
4242
import com.influxdb.query.FluxRecord;
4343
import com.influxdb.query.FluxTable;
@@ -50,11 +50,11 @@
5050
/**
5151
* @author Jakub Bednar (bednar@github) (03/21/2022 07:54)
5252
*/
53-
final class InvocableScriptsApiImpl extends AbstractQueryApi implements InvocableScriptsApi {
53+
final class InvokableScriptsApiImpl extends AbstractQueryApi implements InvokableScriptsApi {
5454

55-
private final InvocableScriptsService service;
55+
private final InvokableScriptsService service;
5656

57-
InvocableScriptsApiImpl(@Nonnull final InvocableScriptsService service) {
57+
InvokableScriptsApiImpl(@Nonnull final InvokableScriptsService service) {
5858
super(new FluxCsvParser(FluxCsvParser.ResponseMetadataMode.ONLY_NAMES));
5959

6060
Arguments.checkNotNull(service, "service");
@@ -85,12 +85,12 @@ public Script updateScript(@Nonnull final String scriptId, @Nonnull final Script
8585
@Nonnull
8686
@Override
8787
public List<Script> findScripts() {
88-
return findScripts(new InvocableScriptsQuery());
88+
return findScripts(new InvokableScriptsQuery());
8989
}
9090

9191
@Nonnull
9292
@Override
93-
public List<Script> findScripts(@Nonnull final InvocableScriptsQuery query) {
93+
public List<Script> findScripts(@Nonnull final InvokableScriptsQuery query) {
9494

9595
Arguments.checkNotNull(query, "query");
9696

client/src/test/java/com/influxdb/client/InvocableScriptsApiTest.java client/src/test/java/com/influxdb/client/InvokableScriptsApiTest.java

+12-12
Original file line numberDiff line numberDiff line change
@@ -38,26 +38,26 @@
3838
import org.junit.runner.RunWith;
3939

4040
@RunWith(JUnitPlatform.class)
41-
class InvocableScriptsApiTest extends AbstractInfluxDBClientTest {
41+
class InvokableScriptsApiTest extends AbstractInfluxDBClientTest {
4242

4343
static final String SUCCESS_DATA = ",result,table,_start,_stop,_time,_value,_field,_measurement,host,value\n"
4444
+ ",,0,1970-01-01T00:00:10Z,1970-01-01T00:00:20Z,1970-01-01T00:00:10Z,10,free,mem,A,12.25\n"
4545
+ ",,1,1970-01-01T00:00:10Z,1970-01-01T00:00:20Z,1970-01-01T00:00:10Z,10,free,mem,A,15.55\n";
4646

47-
private InvocableScriptsApi invocableScriptsApi;
47+
private InvokableScriptsApi invokableScriptsApi;
4848

4949
@BeforeEach
5050
protected void setUp() {
5151
super.setUp();
5252

53-
invocableScriptsApi = influxDBClient.getInvocableScriptsApi();
53+
invokableScriptsApi = influxDBClient.getInvokableScriptsApi();
5454
}
5555

5656
@Test
5757
public void queryFluxTable() {
5858
mockServer.enqueue(createResponse(SUCCESS_DATA));
5959

60-
List<FluxTable> tables = invocableScriptsApi.invokeScript("script_id", new HashMap<>());
60+
List<FluxTable> tables = invokableScriptsApi.invokeScript("script_id", new HashMap<>());
6161
Assertions.assertThat(tables).hasSize(2);
6262
Assertions.assertThat(tables.get(0).getRecords()).hasSize(1);
6363
Assertions.assertThat(tables.get(0).getRecords().get(0).getValues().get("value")).isEqualTo("12.25");
@@ -71,7 +71,7 @@ public void queryStreamFluxRecordFluxTable() {
7171

7272
List<FluxRecord> records = new ArrayList<>();
7373
CountDownLatch recordsCountDown = new CountDownLatch(2);
74-
invocableScriptsApi.invokeScript("script_id", new HashMap<>(), (cancellable, fluxRecord) -> {
74+
invokableScriptsApi.invokeScript("script_id", new HashMap<>(), (cancellable, fluxRecord) -> {
7575
records.add(fluxRecord);
7676
recordsCountDown.countDown();
7777
});
@@ -87,7 +87,7 @@ public void queryStreamFluxRecordFluxTable() {
8787
public void queryMeasurements() {
8888
mockServer.enqueue(createResponse(SUCCESS_DATA));
8989

90-
List<InvocableScriptsPojo> pojos = invocableScriptsApi.invokeScript("script_id", new HashMap<>(), InvocableScriptsPojo.class);
90+
List<InvokableScriptsPojo> pojos = invokableScriptsApi.invokeScript("script_id", new HashMap<>(), InvokableScriptsPojo.class);
9191
Assertions.assertThat(pojos).hasSize(2);
9292
Assertions.assertThat(pojos.get(0).value).isEqualTo("12.25");
9393
Assertions.assertThat(pojos.get(0).host).isEqualTo("A");
@@ -99,10 +99,10 @@ public void queryMeasurements() {
9999
public void queryStreamMeasurements() {
100100
mockServer.enqueue(createResponse(SUCCESS_DATA));
101101

102-
List<InvocableScriptsPojo> pojos = new ArrayList<>();
102+
List<InvokableScriptsPojo> pojos = new ArrayList<>();
103103
CountDownLatch measurementsCountDown = new CountDownLatch(2);
104-
invocableScriptsApi.invokeScript("script_id", new HashMap<>(), InvocableScriptsPojo.class, (cancellable, invocableScriptsPojo) -> {
105-
pojos.add(invocableScriptsPojo);
104+
invokableScriptsApi.invokeScript("script_id", new HashMap<>(), InvokableScriptsPojo.class, (cancellable, invokableScriptsPojo) -> {
105+
pojos.add(invokableScriptsPojo);
106106
measurementsCountDown.countDown();
107107
});
108108

@@ -119,7 +119,7 @@ public void queryStreamMeasurements() {
119119
public void queryRaw() {
120120
mockServer.enqueue(createResponse(SUCCESS_DATA));
121121

122-
String response = invocableScriptsApi.invokeScriptRaw("script_id", new HashMap<>());
122+
String response = invokableScriptsApi.invokeScriptRaw("script_id", new HashMap<>());
123123
Assertions.assertThat(response).isEqualToIgnoringNewLines(SUCCESS_DATA);
124124
}
125125

@@ -129,7 +129,7 @@ public void queryStreamRaw() {
129129

130130
List<String> lines = new ArrayList<>();
131131
CountDownLatch linesCountDown = new CountDownLatch(3);
132-
invocableScriptsApi.invokeScriptRaw("script_id", new HashMap<>(), (cancellable, line) -> {
132+
invokableScriptsApi.invokeScriptRaw("script_id", new HashMap<>(), (cancellable, line) -> {
133133
lines.add(line);
134134
linesCountDown.countDown();
135135
});
@@ -143,7 +143,7 @@ public void queryStreamRaw() {
143143
}
144144

145145
@SuppressWarnings("NewClassNamingConvention")
146-
public static class InvocableScriptsPojo {
146+
public static class InvokableScriptsPojo {
147147

148148
@Column(name = "host", tag = true)
149149
String host;

examples/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ This directory contains Java, Kotlin and Scala examples.
77
- [ParameterizedQuery.java](src/main/java/example/ParameterizedQuery.java) - How to use Parameterized Queries
88

99
### Others
10-
- [InvocableScripts.java](src/main/java/example/InvocableScripts.java) - How to use Invocable scripts Cloud API to create custom endpoints that query data
10+
- [InvokableScripts.java](src/main/java/example/InvokableScripts.java) - How to use Invokable scripts Cloud API to create custom endpoints that query data
1111
- [InfluxDBEnterpriseExample.java](src/main/java/example/InfluxDBEnterpriseExample.java) - How to use `consistency` parameter for InfluxDB Enterprise
1212

1313
## Kotlin

examples/src/main/java/example/InvocableScripts.java examples/src/main/java/example/InvokableScripts.java

+5-5
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828
import com.influxdb.client.InfluxDBClient;
2929
import com.influxdb.client.InfluxDBClientFactory;
30-
import com.influxdb.client.InvocableScriptsApi;
30+
import com.influxdb.client.InvokableScriptsApi;
3131
import com.influxdb.client.domain.Script;
3232
import com.influxdb.client.domain.ScriptCreateRequest;
3333
import com.influxdb.client.domain.ScriptLanguage;
@@ -36,7 +36,7 @@
3636
import com.influxdb.query.FluxRecord;
3737
import com.influxdb.query.FluxTable;
3838

39-
public class InvocableScripts {
39+
public class InvokableScripts {
4040

4141
//
4242
// Define credentials
@@ -56,10 +56,10 @@ public static void main(final String[] args) {
5656
Point point2 = Point.measurement("my_measurement").addTag("location", "New York").addField("temperature", 24.3);
5757
client.getWriteApiBlocking().writePoints(bucket, org, Arrays.asList(point1, point2));
5858

59-
InvocableScriptsApi scriptsApi = client.getInvocableScriptsApi();
59+
InvokableScriptsApi scriptsApi = client.getInvokableScriptsApi();
6060

6161
//
62-
// Create Invocable Script
62+
// Create Invokable Script
6363
//
6464
System.out.println("------- Create -------\n");
6565
ScriptCreateRequest createRequest = new ScriptCreateRequest()
@@ -71,7 +71,7 @@ public static void main(final String[] args) {
7171
System.out.println(createdScript);
7272

7373
//
74-
// Update Invocable Script
74+
// Update Invokable Script
7575
//
7676
System.out.println("------- Update -------\n");
7777
ScriptUpdateRequest updateRequest = new ScriptUpdateRequest().description("my updated description");

0 commit comments

Comments
 (0)