Skip to content

Commit 26c653e

Browse files
AmitMYbrandyscarney
authored andcommittedMay 5, 2017
feat(item): deprecate item-left / item-right attributes for item-start / item-end (#11125)
item-start and item-end make more sense for RTL * refactor(item): replaced item-left with item-start replaced item-right with item-end * style(item): fix spacing * fix(item): add backwards support for left/right in ng-content * fix(item): deprecated old variables, not breaking change * fix(scss): fix variable name * fix(item): old attributes deprecated support
1 parent 6d11499 commit 26c653e

File tree

73 files changed

+663
-582
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

73 files changed

+663
-582
lines changed
 

‎demos/src/item-sliding/pages/page-one/page-one.html

+3-3
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@
1616

1717
<ion-item-sliding *ngFor="let chat of chats" #item>
1818
<ion-item>
19-
<ion-avatar item-left>
19+
<ion-avatar item-start>
2020
<img [src]="chat.img">
2121
</ion-avatar>
2222
<h2>{{chat.name}}</h2>
2323
<p>{{chat.message}}</p>
24-
<ion-note item-right>
24+
<ion-note item-end>
2525
{{chat.time}}
2626
</ion-note>
2727
</ion-item>
@@ -58,7 +58,7 @@ <h2>{{chat.name}}</h2>
5858

5959
<ion-item-sliding *ngFor="let login of logins" #item>
6060
<ion-item>
61-
<ion-icon [name]="login.icon" item-left></ion-icon>
61+
<ion-icon [name]="login.icon" item-start></ion-icon>
6262
<h2>{{login.name}}</h2>
6363
<p>{{login.username}}</p>
6464
</ion-item>

‎demos/src/item/pages/page-one/page-one.html

+19-19
Original file line numberDiff line numberDiff line change
@@ -12,51 +12,51 @@
1212
<ion-list>
1313
<ion-list-header>
1414
Settings
15-
<button ion-button icon-only item-right clear>
15+
<button ion-button icon-only item-end clear>
1616
<ion-icon name="cog"></ion-icon>
1717
</button>
1818
</ion-list-header>
1919

2020
<ion-item-group>
2121
<ion-item>
22-
<ion-icon name="plane" item-left color="danger"></ion-icon>
22+
<ion-icon name="plane" item-start color="danger"></ion-icon>
2323
<ion-label>Airplane Mode</ion-label>
2424
<ion-toggle color="secondary"></ion-toggle>
2525
</ion-item>
2626

2727
<button ion-item>
28-
<ion-icon name="wifi" item-left color="primary"></ion-icon>
28+
<ion-icon name="wifi" item-start color="primary"></ion-icon>
2929
<ion-label>Wi-Fi</ion-label>
30-
<ion-note item-right>The Interwebz</ion-note>
30+
<ion-note item-end>The Interwebz</ion-note>
3131
</button>
3232

3333
<button ion-item>
34-
<ion-icon name="bluetooth" item-left color="primary"></ion-icon>
34+
<ion-icon name="bluetooth" item-start color="primary"></ion-icon>
3535
<ion-label>Bluetooth</ion-label>
36-
<ion-note item-right>Off</ion-note>
36+
<ion-note item-end>Off</ion-note>
3737
</button>
3838
</ion-item-group>
3939

4040
<ion-item-divider color="primary">
4141
Other Settings
42-
<button ion-button item-right outline color="light">Clear</button>
42+
<button ion-button item-end outline color="light">Clear</button>
4343
</ion-item-divider>
4444

4545
<button ion-item>
46-
<ion-icon name="call" item-left color="secondary"></ion-icon>
46+
<ion-icon name="call" item-start color="secondary"></ion-icon>
4747
<ion-label>Cellular</ion-label>
4848
</button>
4949

5050
<button ion-item>
51-
<ion-icon name="link" item-left color="secondary"></ion-icon>
51+
<ion-icon name="link" item-start color="secondary"></ion-icon>
5252
<ion-label>Personal Hotspot</ion-label>
53-
<ion-note item-right>Off</ion-note>
53+
<ion-note item-end>Off</ion-note>
5454
</button>
5555
</ion-list>
5656

5757
<ion-list radio-group>
5858
<ion-list-header>
59-
<ion-icon item-left name="phone-portrait"></ion-icon>
59+
<ion-icon item-start name="phone-portrait"></ion-icon>
6060
Silence Phone
6161
</ion-list-header>
6262

@@ -76,24 +76,24 @@
7676
</ion-list-header>
7777

7878
<ion-item>
79-
<ion-icon name="ionic" item-left color="primary"></ion-icon>
79+
<ion-icon name="ionic" item-start color="primary"></ion-icon>
8080
<ion-label>Ionic View</ion-label>
81-
<button ion-button outline item-right>Uninstall</button>
81+
<button ion-button outline item-end>Uninstall</button>
8282
</ion-item>
8383
<ion-item>
84-
<ion-icon name="brush" item-left color="primary"></ion-icon>
84+
<ion-icon name="brush" item-start color="primary"></ion-icon>
8585
<ion-label>Ionic Creator</ion-label>
86-
<button ion-button outline item-right>Uninstall</button>
86+
<button ion-button outline item-end>Uninstall</button>
8787
</ion-item>
8888
<ion-item>
89-
<ion-icon name="logo-octocat" item-left color="dark"></ion-icon>
89+
<ion-icon name="logo-octocat" item-start color="dark"></ion-icon>
9090
<ion-label>Hubstruck</ion-label>
91-
<button ion-button outline item-right>Uninstall</button>
91+
<button ion-button outline item-end>Uninstall</button>
9292
</ion-item>
9393
<ion-item>
94-
<ion-icon name="paw" item-left color="danger"></ion-icon>
94+
<ion-icon name="paw" item-start color="danger"></ion-icon>
9595
<ion-label>Barkpark</ion-label>
96-
<button ion-button outline item-right>Uninstall</button>
96+
<button ion-button outline item-end>Uninstall</button>
9797
</ion-item>
9898
</ion-list>
9999

0 commit comments

Comments
 (0)
Please sign in to comment.