metrics: add transport label to p2p_peers_total #2728
Conversation
| for _, conn := range c.Node.PeerHost.Network().Conns() { | ||
| tr := "" | ||
| for _, proto := range conn.RemoteMultiaddr().Protocols() { | ||
| tr = tr + "/" + proto.Name |
There was a problem hiding this comment.
Maybe this would be good to have in go-multiaddr, Multiaddr.ProtocolsString()
ghost
mentioned this pull request
|
Hold on, I'll also add a version label, so that we can also graph peer counts by remote-version. |
|
Mh does anything store the remote version? The peerstore maybe? I don't wanna fire any requests, just read existing data. |
|
Ok let's go ahead with this one, without remote-version.
|
ghost
added
RFCR
and removed
need/author-input
| func (c IpfsNodeCollector) PeersTotalValue() float64 { | ||
| return float64(len(c.Node.PeerHost.Network().Conns())) | ||
| func (c IpfsNodeCollector) PeersTotalValues() map[string]float64 { | ||
| vals := map[string]float64{} |
There was a problem hiding this comment.
i prefer using make for this
|
I think we store the remote version in the peerstore, although we can add that in later. |
|
aside from one nitpick, this LGTM |
Gives us per-transport peers counts:
ipfs_p2p_peers_total{transport="/ip4/tcp"} 25
ipfs_p2p_peers_total{transport="/ip6/tcp"} 13
ipfs_p2p_peers_total{transport="/ip6/udp/utp"} 17
License: MIT
Signed-off-by: Lars Gierth <larsg@systemli.org>
ghost
force-pushed
the
peers-total-by-transport
branch
from
91e141f to
05cb7a1
Compare
ghost
mentioned this pull request
Gives us per-transport peers counts:
License: MIT
Signed-off-by: Lars Gierth larsg@systemli.org