Merge pull request #34 from ipfs/fix/fast-read

Stebalien · web-flow · commit de6f1daf92a1 · 2019-02-28T15:07:55.000-08:00
fix some performance regressions when reading protobuf nodes
diff --git a/coding.go b/coding.go
@@ -131,7 +131,7 @@ func DecodeProtobufBlock(b blocks.Block) (ipld.Node, error) {
 	}
 
 	decnd.cached = c
-	decnd.SetCidBuilder(c.Prefix())
+	decnd.builder = c.Prefix()
 	return decnd, nil
 }
 
diff --git a/node.go b/node.go
@@ -78,7 +78,6 @@ func (n *ProtoNode) SetCidBuilder(builder cid.Builder) {
 		n.builder = v0CidPrefix
 	} else {
 		n.builder = builder.WithCodec(cid.DagProtobuf)
-		n.encoded = nil
 		n.cached = cid.Undef
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,7 @@ func DecodeProtobufBlock(b blocks.Block) (ipld.Node, error) {`
`131`	`131`	`}`
`132`	`132`
`133`	`133`	`decnd.cached = c`
`134`		`- decnd.SetCidBuilder(c.Prefix())`
	`134`	`+ decnd.builder = c.Prefix()`
`135`	`135`	`return decnd, nil`
`136`	`136`	`}`
`137`	`137`
Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,6 @@ func (n *ProtoNode) SetCidBuilder(builder cid.Builder) {`
`78`	`78`	`n.builder = v0CidPrefix`
`79`	`79`	`} else {`
`80`	`80`	`n.builder = builder.WithCodec(cid.DagProtobuf)`
`81`		`- n.encoded = nil`
`82`	`81`	`n.cached = cid.Undef`
`83`	`82`	`}`
`84`	`83`	`}`