Skip to content

Commit 0bd8431

Browse files
committed
Call setExpvarOptions method inside Initialize
Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
1 parent 2123f10 commit 0bd8431

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

plugin/storage/factory.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ func NewFactory(config FactoryConfig) (*Factory, error) {
8282
}
8383
f.factories[t] = ff
8484
}
85-
f.setExpvarOptions()
8685
return f, nil
8786
}
8887

@@ -113,6 +112,7 @@ func (f *Factory) Initialize(metricsFactory metrics.Factory, logger *zap.Logger)
113112
return err
114113
}
115114
}
115+
f.setExpvarOptions()
116116
return nil
117117
}
118118

plugin/storage/factory_test.go

+4
Original file line numberDiff line numberDiff line change
@@ -358,6 +358,10 @@ func TestSetExpvarOptions(t *testing.T) {
358358
f, err := NewFactory(defaultCfg())
359359
require.NoError(t, err)
360360

361+
m := metrics.NullFactory
362+
l := zap.NewNop()
363+
f.Initialize(m, l)
364+
361365
gotDownsamplingRatio := expvar.Get(downsamplingRatio)
362366

363367
assert.Equal(t, f.DownsamplingRatio, gotDownsamplingRatio)

0 commit comments

Comments
 (0)