Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test TestTBufferedServer_Metrics #2631

Closed
yurishkuro opened this issue Nov 16, 2020 · 0 comments · Fixed by #2635
Closed

Flaky test TestTBufferedServer_Metrics #2631

yurishkuro opened this issue Nov 16, 2020 · 0 comments · Fixed by #2635
Labels
bug good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@yurishkuro
Copy link
Member

it strikes again https://travis-ci.com/github/yurishkuro/jaeger/jobs/440719322#L679

=== RUN   TestTBufferedServer_Metrics
    metricstest.go:49: 
        	Error Trace:	metricstest.go:49
        	            				metricstest.go:37
        	            				tbuffered_server_test.go:156
        	Error:      	Not equal: 
        	            	expected: int(1)
        	            	actual  : int64(0)
        	Test:       	TestTBufferedServer_Metrics
        	Messages:   	expected metric name: thrift.udp.server.read.errors, tags: map[]
--- FAIL: TestTBufferedServer_Metrics (0.01s)
FAIL
coverage: 97.3% of statements
FAIL	github.com/jaegertracing/jaeger/cmd/agent/app/servers	0.051s
@yurishkuro yurishkuro added bug help wanted Features that maintainers are willing to accept but do not have cycles to implement good first issue Good for beginners labels Nov 16, 2020
@yurishkuro yurishkuro changed the title Flake test TestTBufferedServer_Metrics Flaky test TestTBufferedServer_Metrics Nov 16, 2020
@pkositsyn pkositsyn mentioned this issue Nov 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flaky tbuffered server test pkositsyn/jaeger
1 participant
@yurishkuro