Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Badger Integration Test Failures #2659

Closed
Ashmita152 opened this issue Nov 27, 2020 · 1 comment · Fixed by #2660
Closed

Badger Integration Test Failures #2659

Ashmita152 opened this issue Nov 27, 2020 · 1 comment · Fixed by #2660
Labels
bug

Comments

@Ashmita152
Copy link
Contributor

Describe the bug
We cleaned up the badger factory close() as part of this #2643 but we forgot to update the integration tests accordingly since travis is broken.

--- FAIL: TestBadgerStorage (46.09s)
    --- FAIL: TestBadgerStorage/GetServices (0.01s)
    --- FAIL: TestBadgerStorage/GetOperations (0.01s)
    --- FAIL: TestBadgerStorage/GetTrace (0.01s)
        --- PASS: TestBadgerStorage/GetTrace/NotFound_error (0.00s)
    --- FAIL: TestBadgerStorage/GetLargeSpans (24.18s)
    --- FAIL: TestBadgerStorage/FindTraces (21.80s)
        --- PASS: TestBadgerStorage/FindTraces/Tags_in_one_spot_-_Tags (0.01s)
        --- PASS: TestBadgerStorage/FindTraces/Tags_in_one_spot_-_Logs (0.01s)
        --- PASS: TestBadgerStorage/FindTraces/Tags_in_one_spot_-_Process (0.01s)
        --- PASS: TestBadgerStorage/FindTraces/Tags_in_different_spots (0.01s)
        --- PASS: TestBadgerStorage/FindTraces/Trace_spans_over_multiple_indices (0.01s)
        --- PASS: TestBadgerStorage/FindTraces/Operation_name (0.01s)
        --- PASS: TestBadgerStorage/FindTraces/Operation_name_+_max_Duration (0.01s)
        --- PASS: TestBadgerStorage/FindTraces/Operation_name_+_Duration_range (0.01s)
        --- PASS: TestBadgerStorage/FindTraces/Duration_range (0.01s)
        --- PASS: TestBadgerStorage/FindTraces/max_Duration (0.01s)
        --- FAIL: TestBadgerStorage/FindTraces/default (21.59s)
        --- PASS: TestBadgerStorage/FindTraces/Tags_+_Operation_name (0.01s)
        --- PASS: TestBadgerStorage/FindTraces/Tags_+_Operation_name_+_max_Duration (0.01s)
        --- PASS: TestBadgerStorage/FindTraces/Tags_+_Operation_name_+_Duration_range (0.01s)
        --- PASS: TestBadgerStorage/FindTraces/Tags_+_Duration_range (0.01s)
        --- PASS: TestBadgerStorage/FindTraces/Tags_+_max_Duration (0.01s)
        --- PASS: TestBadgerStorage/FindTraces/Multi-spot_Tags_+_Operation_name (0.01s)
        --- PASS: TestBadgerStorage/FindTraces/Multi-spot_Tags_+_Operation_name_+_max_Duration (0.01s)
        --- PASS: TestBadgerStorage/FindTraces/Multi-spot_Tags_+_Operation_name_+_Duration_range (0.01s)
        --- PASS: TestBadgerStorage/FindTraces/Multi-spot_Tags_+_Duration_range (0.01s)
        --- PASS: TestBadgerStorage/FindTraces/Multi-spot_Tags_+_max_Duration (0.01s)
        --- PASS: TestBadgerStorage/FindTraces/Multiple_Traces (0.02s)
    --- SKIP: TestBadgerStorage/GetDependencies (0.00s)

To Reproduce
Steps to reproduce the behavior:

  1. make mem-and-badger-storage-integration-test

Expected behavior
Tests should pass.
@Ashmita152 Ashmita152 added the bug label Nov 27, 2020
@Ashmita152 Ashmita152 mentioned this issue Nov 27, 2020
Merged
@yurishkuro
Copy link
Member

Good catch - we need to restore the CI asap, it would've caught this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for failures in badger integration tests
2 participants
@yurishkuro @Ashmita152