improved error handling

zevv · zevv · commit 52d1fbfaee7e · 2023-05-18T10:42:14.000+02:00
diff --git a/src/core/ev.c b/src/core/ev.c
@@ -2495,14 +2495,14 @@ static JanetAsyncStatus handle_connect(JanetListenerState *s) {
         if (res == 0) {
             janet_schedule(s->fiber, janet_wrap_abstract(s->stream));
         } else {
-            janet_cancel(s->fiber, janet_cstringv(strerror(res)));
             // TODO help needed. janet_stream_close(s->stream);
+            janet_cancel(s->fiber, janet_cstringv(strerror(res)));
         }
-        return JANET_ASYNC_STATUS_DONE;
     } else {
-        // TODO panic? assert?
-        return JANET_ASYNC_STATUS_NOT_DONE;
+        // TODO help needed. janet_stream_close(s->stream);
+        janet_cancel(s->fiber, janet_ev_lasterr());
     }
+    return JANET_ASYNC_STATUS_DONE;
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -2495,14 +2495,14 @@ static JanetAsyncStatus handle_connect(JanetListenerState *s) {`
`2495`	`2495`	`if (res == 0) {`
`2496`	`2496`	`janet_schedule(s->fiber, janet_wrap_abstract(s->stream));`
`2497`	`2497`	`} else {`
`2498`		`- janet_cancel(s->fiber, janet_cstringv(strerror(res)));`
`2499`	`2498`	`// TODO help needed. janet_stream_close(s->stream);`
	`2499`	`+ janet_cancel(s->fiber, janet_cstringv(strerror(res)));`
`2500`	`2500`	`}`
`2501`		`- return JANET_ASYNC_STATUS_DONE;`
`2502`	`2501`	`} else {`
`2503`		`- // TODO panic? assert?`
`2504`		`- return JANET_ASYNC_STATUS_NOT_DONE;`
	`2502`	`+ // TODO help needed. janet_stream_close(s->stream);`
	`2503`	`+ janet_cancel(s->fiber, janet_ev_lasterr());`
`2505`	`2504`	`}`
	`2505`	`+ return JANET_ASYNC_STATUS_DONE;`
`2506`	`2506`	`}`
`2507`	`2507`
`2508`	`2508`