Rubocop updates (v1.73) (#418)

Author: jcraigk

.rubocop.yml

@@ -4,85 +4,33 @@ inherit_gem:
 require:
   - rubocop-capybara
   - rubocop-factory_bot
+  - rubocop-rspec_rails
+
+plugins:
   - rubocop-performance
   - rubocop-rake
   - rubocop-rspec
-  - rubocop-rspec_rails
 
 AllCops:
-  Exclude:
-    - bin/*
-    - db/**/*
-    - vendor/**/*
-    - lib/tasks/*
   NewCops: enable
   TargetRubyVersion: 3.4.1
 
 FactoryBot/ExcessiveCreateList:
   Enabled: false
-Layout/EmptyLineAfterGuardClause:
-  Enabled: false
-Layout/EmptyLineAfterMagicComment:
-  Enabled: false
-Layout/LineLength:
-  Max: 100
-Metrics/BlockLength:
-  Exclude:
-    - spec/**/*
-    - app/api/**/*
-    - config/routes.rb
-Metrics/ClassLength:
-  Max: 250
-Metrics/ModuleLength:
-  Max: 250
-RSpec/DescribeClass:
-  Exclude:
-    - spec/features/**/*
 RSpec/ExampleLength:
   Exclude:
     - spec/features/**/*
     - spec/requests/**/*
 RSpec/IndexedLet:
   Enabled: false
-Rails/EnvironmentVariableAccess:
-  Enabled: false
-Rails/Exit:
-  Enabled: false
-Rails/FilePath:
-  Enabled: false
-Rails/HttpPositionalArguments:
-  Enabled: false
-Rails/I18nLocaleTexts:
-  Enabled: false
-Rails/SkipsModelValidations:
-  Enabled: false
-RSpec/ImplicitSubject:
-  EnforcedStyle: single_statement_only
 RSpec/MultipleExpectations:
   Exclude:
     - spec/features/**/*
     - spec/requests/**/*
   Max: 4
-Rails/Output:
-  Enabled: false
-Rails/OutputSafety:
-  Enabled: false
 RSpec/MultipleMemoizedHelpers:
   Enabled: false
 RSpec/NestedGroups:
   Max: 4
 RSpecRails/HaveHttpStatus: # We use Rack::MockResponse
   Enabled: false
-Style/ClassAndModuleChildren:
-  Enabled: false
-Style/Documentation:
-  Enabled: false
-Style/FormatStringToken:
-  Enabled: false
-Style/FrozenStringLiteralComment:
-  EnforcedStyle: never
-Style/HashTransformValues:
-  Enabled: false
-Style/MissingRespondToMissing:
-  Exclude:
-    - app/services/**/*

Gemfile

@@ -46,7 +46,6 @@ group :development do
   gem "rubocop-capybara"
   gem "rubocop-factory_bot"
   gem "rubocop-performance"
-  gem "rubocop-rails-omakase", require: false
   gem "rubocop-rake"
   gem "rubocop-rspec_rails"
   gem "rubocop-rspec"

Gemfile.lock

@@ -387,7 +387,7 @@ GEM
       rspec-mocks (~> 3.13)
       rspec-support (~> 3.13)
     rspec-support (3.13.2)
-    rubocop (1.72.2)
+    rubocop (1.73.0)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
@@ -398,31 +398,16 @@ GEM
       rubocop-ast (>= 1.38.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.38.0)
+    rubocop-ast (1.38.1)
       parser (>= 3.3.1.0)
     rubocop-capybara (2.21.0)
       rubocop (~> 1.41)
     rubocop-factory_bot (2.26.1)
       rubocop (~> 1.61)
-    rubocop-minitest (0.37.1)
-      lint_roller (~> 1.1)
-      rubocop (>= 1.72.1, < 2.0)
-      rubocop-ast (>= 1.38.0, < 2.0)
     rubocop-performance (1.24.0)
       lint_roller (~> 1.1)
       rubocop (>= 1.72.1, < 2.0)
       rubocop-ast (>= 1.38.0, < 2.0)
-    rubocop-rails (2.30.1)
-      activesupport (>= 4.2.0)
-      lint_roller (~> 1.1)
-      rack (>= 1.1)
-      rubocop (>= 1.72.1, < 2.0)
-      rubocop-ast (>= 1.38.0, < 2.0)
-    rubocop-rails-omakase (1.0.0)
-      rubocop
-      rubocop-minitest
-      rubocop-performance
-      rubocop-rails
     rubocop-rake (0.7.1)
       lint_roller (~> 1.1)
       rubocop (>= 1.72.1)
@@ -512,9 +497,9 @@ GEM
       unicode-emoji (~> 4.0, >= 4.0.4)
     unicode-emoji (4.0.4)
     uniform_notifier (1.16.0)
-    uri (1.0.2)
+    uri (1.0.3)
     useragent (0.16.11)
-    version_gem (1.1.5)
+    version_gem (1.1.6)
     waveform (0.1.3)
       chunky_png
       ruby-audio
@@ -566,7 +551,6 @@ DEPENDENCIES
   rubocop-capybara
   rubocop-factory_bot
   rubocop-performance
-  rubocop-rails-omakase
   rubocop-rake
   rubocop-rspec
   rubocop-rspec_rails

db/migrate/20120816185619_create_tracks.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class CreateTracks < ActiveRecord::Migration
   def change
     create_table :tracks do |t|

db/migrate/20120816185625_create_songs_tracks.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class CreateSongsTracks < ActiveRecord::Migration
   def change
     create_table :songs_tracks do |t|

db/migrate/20120816234607_add_audio_file_field_to_track.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class AddAudioFileFieldToTrack < ActiveRecord::Migration
   def up
     add_attachment :tracks, :audio_file

db/migrate/20121107030749_create_venues.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class CreateVenues < ActiveRecord::Migration
   def change
     create_table :venues do |t|

db/migrate/20121107055322_add_venue_id_to_shows.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class AddVenueIdToShows < ActiveRecord::Migration
   def change
     add_column :shows, :venue_id, :integer

db/migrate/20121108010949_create_tours.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class CreateTours < ActiveRecord::Migration
   def change
     create_table :tours do |t|

db/migrate/20121108011416_add_tour_id_to_shows.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class AddTourIdToShows < ActiveRecord::Migration
   def change
     add_column :shows, :tour_id, :integer

db/migrate/20121111015203_add_set_to_track.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class AddSetToTrack < ActiveRecord::Migration
   def change
     add_column :tracks, :set, :string

db/migrate/20121202033002_create_albums.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class CreateAlbums < ActiveRecord::Migration
   def change
     create_table :albums do |t|

db/migrate/20130223222601_add_counter_caches_to_venues_and_tours.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class AddCounterCachesToVenuesAndTours < ActiveRecord::Migration
   def change
     add_column :venues, :shows_count, :integer, default: 0

db/migrate/20130225005015_devise_create_users.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class DeviseCreateUsers < ActiveRecord::Migration
   def change
     create_table(:users) do |t|

db/migrate/20130225044130_add_lyrical_excerpt_to_songs.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class AddLyricalExcerptToSongs < ActiveRecord::Migration
   def change
     add_column :songs, :lyrical_excerpt, :string

db/migrate/20130302031026_create_likes.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class CreateLikes < ActiveRecord::Migration
   def change
     create_table :likes do |t|

db/migrate/20130303234422_add_error_to_albums.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class AddErrorToAlbums < ActiveRecord::Migration
   def change
     add_column :albums, :error_at, :datetime

db/migrate/20130323013212_add_geocoding_to_venues.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class AddGeocodingToVenues < ActiveRecord::Migration
   def change
     add_column :venues, :latitude, :float

db/migrate/20130324014414_create_rails_admin_histories_table.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class CreateRailsAdminHistoriesTable < ActiveRecord::Migration
   def self.up
     create_table :rails_admin_histories do |t|

db/migrate/20130330035726_add_slug_to_tracks.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class AddSlugToTracks < ActiveRecord::Migration
   def change
     add_column :tracks, :slug, :string

db/migrate/20130331022600_create_track_request.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class CreateTrackRequest < ActiveRecord::Migration
   def change
     create_table :track_requests do |t|

db/migrate/20130331022752_create_album_requests.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class CreateAlbumRequests < ActiveRecord::Migration
   def change
     create_table :album_requests do |t|

db/migrate/20130406004938_add_username_to_users.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class AddUsernameToUsers < ActiveRecord::Migration
   def change
     add_column :users, :username, :string, null: false, default: ''

db/migrate/20130406075115_add_completion_flags_to_shows.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class AddCompletionFlagsToShows < ActiveRecord::Migration
   def change
     add_column :shows, :incomplete, :boolean, default: false

db/migrate/20130407050657_add_admin_notes_to_shows.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class AddAdminNotesToShows < ActiveRecord::Migration
   def change
     add_column :shows, :admin_notes, :text

db/migrate/20130407215439_remove_location_from_shows.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class RemoveLocationFromShows < ActiveRecord::Migration
   def change
     remove_column :shows, :location

db/migrate/20130414231746_change_venues.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class ChangeVenues < ActiveRecord::Migration
   def change
     remove_column :venues, :vague_location

db/migrate/20130415030315_add_duration_to_shows.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class AddDurationToShows < ActiveRecord::Migration
   def change
     add_column :shows, :duration, :integer, null: false, default: 0

db/migrate/20130416030421_create_playlists.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class CreatePlaylists < ActiveRecord::Migration
   def change
     create_table :playlists do |t|

db/migrate/20130421233021_create_tags.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class CreateTags < ActiveRecord::Migration
   def change
     create_table :tags do |t|

db/migrate/20130525010829_playlist_bookmark.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class PlaylistBookmark < ActiveRecord::Migration
   def change
     create_table :playlist_bookmarks do |t|

db/migrate/20130526053130_add_duration_to_playlists.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class AddDurationToPlaylists < ActiveRecord::Migration
   def change
     add_column :playlists, :duration, :integer, default: 0

db/migrate/20140801220314_add_taper_notes_to_shows.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class AddTaperNotesToShows < ActiveRecord::Migration
   def change
     add_column :shows, :taper_notes, :text

db/migrate/20150831021223_add_authentication_token_to_users.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class AddAuthenticationTokenToUsers < ActiveRecord::Migration
   def change
     add_column :users, :authentication_token, :string

db/migrate/20150908184304_add_counts_to_tags.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class AddCountsToTags < ActiveRecord::Migration
   def change
     add_column :tags, :shows_count, :integer, default: 0

db/migrate/20150908220110_add_priority_to_tags.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class AddPriorityToTags < ActiveRecord::Migration
   def change
     add_column :tags, :priority, :integer, default: 0

db/migrate/20151011195107_add_tags_count_to_shows_and_tracks.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class AddTagsCountToShowsAndTracks < ActiveRecord::Migration
   def change
     add_column :shows, :tags_count, :integer, default: 0

db/migrate/20151011195314_populate_tags_counts.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class PopulateTagsCounts < ActiveRecord::Migration
   def up
     execute 'update shows set tags_count=(select count(*) from show_tags where show_id=shows.id)'

db/migrate/20170811053628_add_alt_title_to_songs.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class AddAltTitleToSongs < ActiveRecord::Migration
   def change
     add_column :songs, :alt_title, :string

db/migrate/20181027220035_add_notes_to_tag_intersections.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class AddNotesToTagIntersections < ActiveRecord::Migration[5.2]
   def change
     add_column :show_tags, :notes, :text

db/migrate/20181028213134_add_slug_to_tags.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class AddSlugToTags < ActiveRecord::Migration[5.2]
   def change
     add_column :tags, :slug, :string

db/migrate/20181117192618_drop_album_tables.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class DropAlbumTables < ActiveRecord::Migration[5.2]
   def change
     drop_table :albums

db/migrate/20181117234052_drop_track_requests.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class DropTrackRequests < ActiveRecord::Migration[5.2]
   def change
     drop_table :track_requests

db/migrate/20181120044655_drop_rails_admin_histories.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class DropRailsAdminHistories < ActiveRecord::Migration[5.2]
   def change
     drop_table :rails_admin_histories

db/migrate/20181213215523_add_missing_foreign_key_indexes.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class AddMissingForeignKeyIndexes < ActiveRecord::Migration[5.2]
   def change
     add_index :songs_tracks, :song_id

db/migrate/20181214055931_add_missing_unique_indexes.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class AddMissingUniqueIndexes < ActiveRecord::Migration[5.2]
   disable_ddl_transaction!
 

db/migrate/20181214071912_set_required_columns_null_false.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class SetRequiredColumnsNullFalse < ActiveRecord::Migration[5.2]
   def change
     change_column_null :playlists, :name, false

db/migrate/20181214074204_add_timestamps_to_tags.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class AddTimestampsToTags < ActiveRecord::Migration[5.2]
   def change
     add_column :track_tags, :starts_at_second, :integer

db/migrate/20181214080858_venue_rename.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class VenueRename < ActiveRecord::Migration[5.2]
   def change
     create_table :venue_renames do |t|

db/migrate/20181217065408_remove_venue_past_names.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class RemoveVenuePastNames < ActiveRecord::Migration[5.2]
   def change
     remove_column :venues, :past_names, :string

db/migrate/20181217070430_add_published_to_shows.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class AddPublishedToShows < ActiveRecord::Migration[5.2]
   def change
     add_column :shows, :published, :boolean, null: false, default: false