Minor cleanup

Author: jcraigk

.gitignore

@@ -2,6 +2,7 @@
 .DS_Store
 .env
 .yarn-integrity
+/.vscode
 /.yarn
 /coverage
 /log

Gemfile

@@ -47,6 +47,7 @@ group :development do
   gem "rubocop-capybara"
   gem "rubocop-factory_bot"
   gem "rubocop-performance"
+  gem "rubocop-rails-omakase"
   gem "rubocop-rake"
   gem "rubocop-rspec_rails"
   gem "rubocop-rspec"

Gemfile.lock

@@ -409,6 +409,16 @@ GEM
       lint_roller (~> 1.1)
       rubocop (>= 1.72.1, < 2.0)
       rubocop-ast (>= 1.38.0, < 2.0)
+    rubocop-rails (2.30.2)
+      activesupport (>= 4.2.0)
+      lint_roller (~> 1.1)
+      rack (>= 1.1)
+      rubocop (>= 1.72.1, < 2.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
+    rubocop-rails-omakase (1.1.0)
+      rubocop (>= 1.72)
+      rubocop-performance (>= 1.24)
+      rubocop-rails (>= 2.30)
     rubocop-rake (0.7.1)
       lint_roller (~> 1.1)
       rubocop (>= 1.72.1)
@@ -553,6 +563,7 @@ DEPENDENCIES
   rubocop-capybara
   rubocop-factory_bot
   rubocop-performance
+  rubocop-rails-omakase
   rubocop-rake
   rubocop-rspec
   rubocop-rspec_rails

app/models/playlist.rb

@@ -25,9 +25,9 @@ class Playlist < ApplicationRecord
 
   scope :published, -> { where(published: true) }
 
-  after_save :update_duration
+  after_save :save_duration
 
-  def update_duration
+  def save_duration
     update_column(:duration, playlist_tracks.sum(:duration)) if self.persisted?
   end
 

app/models/playlist_track.rb

@@ -7,9 +7,9 @@ class PlaylistTrack < ApplicationRecord
             uniqueness: { scope: :playlist_id }
 
   before_save :assign_duration
-  after_create :update_playlist_duration
-  after_update :update_playlist_duration
-  after_destroy :update_playlist_duration
+  after_create :save_playlist_duration
+  after_update :save_playlist_duration
+  after_destroy :save_playlist_duration
 
   private
 
@@ -32,7 +32,7 @@ def excerpt_duration
     dur.negative? ? track.duration : dur
   end
 
-  def update_playlist_duration
-    playlist.update_duration
+  def save_playlist_duration
+    playlist.save_duration
   end
 end

config/routes.rb

@@ -1,7 +1,7 @@
 require "sidekiq/web"
 
 Rails.application.routes.draw do
-  get "/health", to: proc { [200, {}, ["OK"]] }
+  get "/health", to: proc { [ 200, {}, [ "OK" ] ] }
 
   Sidekiq::Web.use Rack::Auth::Basic do |username, password|
     ActiveSupport::SecurityUtils.secure_compare(

spec/models/playlist_spec.rb

@@ -62,7 +62,7 @@
     end
   end
 
-  describe '#update_duration' do
+  describe '#save_duration' do
     let!(:playlist) { create(:playlist, tracks_count: 3) }
 
     it 'updates the playlist duration after adding tracks' do

spec/models/playlist_track_spec.rb

@@ -80,36 +80,36 @@
       end
     end
 
-    describe '#update_playlist_duration' do
+    describe '#save_playlist_duration' do
       let(:playlist) { create(:playlist) }
 
-      before { allow(playlist).to receive(:update_duration) }
+      before { allow(playlist).to receive(:save_duration) }
 
       describe 'after create' do
-        it 'calls update_duration on the parent playlist' do
+        it 'calls save_duration on the parent playlist' do
           playlist_track = build(:playlist_track, playlist:)
           playlist_track.save
-          expect(playlist).to have_received(:update_duration)
+          expect(playlist).to have_received(:save_duration)
         end
       end
 
       describe 'after update' do
-        before { allow(playlist).to receive(:update_duration) }
+        before { allow(playlist).to receive(:save_duration) }
 
-        it 'calls update_duration on the parent playlist' do
+        it 'calls save_duration on the parent playlist' do
           playlist_track = create(:playlist_track, playlist:)
           playlist_track.update(starts_at_second: 3, ends_at_second: 5)
-          expect(playlist).to have_received(:update_duration).twice
+          expect(playlist).to have_received(:save_duration).twice
         end
       end
 
       describe 'after destroy' do
-        before { allow(playlist).to receive(:update_duration) }
+        before { allow(playlist).to receive(:save_duration) }
 
-        it 'calls update_duration on the parent playlist' do
+        it 'calls save_duration on the parent playlist' do
           playlist_track = create(:playlist_track, playlist:)
           playlist_track.destroy
-          expect(playlist).to have_received(:update_duration).twice
+          expect(playlist).to have_received(:save_duration).twice
         end
       end
     end