Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to Add Option to Select Whether Turn On/Off Spell Check #842

Closed
2 tasks done
zhongxiang117 opened this issue Dec 20, 2021 · 7 comments
Closed
2 tasks done

Comments

@zhongxiang117
Copy link

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Is your feature request related to a problem? Please describe.

Since the first request to disable spell check was fulfilled, it has been around one year that this useful function is not added back. Why to turn if off only on a "single"(open & close issues) request? The fact is not every is using Mac or the native English speaker. Please take it back or at least add an option to let user make their decision.

Describe the solution you'd like

May it be a good solution to modify UI:
image

Describe alternatives you've considered

Or the modification on startup:
image

@davidjgraph davidjgraph transferred this issue from jgraph/drawio Dec 21, 2021
@m-mohamedin
Copy link
Contributor

Will be added to the Extras menu in the next release

@zhongxiang117
Copy link
Author

@ashrafteleb Cool, thank you for your work and consideration!

@zhongxiang117
Copy link
Author

First of all, thanks for your work and consideration for the adding of "Spell checker" option into "Extra" menu starting from v16.1.0.

However, when I tried the new build release v16.1.2 Linux deb version, I found the spell checker does not work even with "Spell checker" turned on.

But, for Windows version, it works very well.

Let me show you the differences;

Linux -- Ubuntu
image

Windows 10
image
image

My Ubuntu info & dpkg version.
image

Could you please take a look into this question? Thanks!

@m-mohamedin
Copy link
Contributor

I think you need to install Hunspell. Electron docs say: "On Windows and Linux this is powered by Hunspell dictionaries, and on macOS it makes use of the native spellchecker APIs."

Could you please try that and let us know?

@zhongxiang117
Copy link
Author

Hi @ashrafteleb, followed your advice, I installed Hunspell, now the spell checker works, thanks!

@sandeepshivhare
Copy link

Does spell check gives recommendation on correction? If yes, then how since I am not able to find any option for suggestion.

@zhongxiang117
Copy link
Author

@sandeepshivhare In my experience, no, it does not give spell suggestion, it only shows the indication on whether the word is "valid" or not, which is defined in the dictionary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants