Fix key names and formatting

Author: lsegal

.rubocop.yml

@@ -1,13 +1,11 @@
 #inherit_from:
 #  - .rubocop_todo.yml
 
-AllCops:
-  TargetRubyVersion: 2.4
-  Exclude:
-    - 'vendor/**/*' # need to reset this apparently
-    - 'lib/yard/parser/ruby/legacy/ruby_lex.rb' # old file, don't touch
 Metrics:
   Enabled: false
+Layout/LineLength:
+  AutoCorrect: true
+  Max: 100
 Style/Semicolon:
   AllowAsExpressionSeparator: true
 Style/Documentation:
@@ -16,53 +14,53 @@ Style/ClassVars:
   Enabled: false
 Style/HashSyntax:
   EnforcedStyle: hash_rockets
-Style/SpaceInsideHashLiteralBraces:
+Layout/SpaceInsideHashLiteralBraces:
   EnforcedStyle: no_space
-Style/SpaceInsideBlockBraces:
+Layout/SpaceInsideBlockBraces:
   SpaceBeforeBlockParameters: false
-Style/MultilineMethodCallIndentation:
-  EnforcedStyle: indented
 Style/NumericPredicate: # ruby 1.8/1.9 do not have positive?/negative?
   EnforcedStyle: comparison
-Style/MultilineMethodCallIndentation:
+Layout/MultilineMethodCallIndentation:
   EnforcedStyle: indented
-Style/DotPosition:
+Layout/DotPosition:
   EnforcedStyle: trailing
 Style/FormatString:
   EnforcedStyle: percent
-Style/IndentArray:
+Layout/FirstArrayElementIndentation:
   EnforcedStyle: consistent
-Style/IndentHash:
+Layout/FirstHashElementIndentation:
   EnforcedStyle: consistent
 
 # Disable these until we know what to do with them
 Style/SafeNavigation:
   Enabled: false # not supported in 1.8...2.1
 Style/GuardClause: # does not provide much value
   Enabled: false
-Style/VariableNumber:
+Naming/VariableNumber:
+  Enabled: false
+Naming/AccessorMethodName: # this creates breaking changes in the API
   Enabled: false
-Style/AccessorMethodName: # this creates breaking changes in the API
+Naming/PredicateName: # this creates breaking changes in the API
   Enabled: false
-Style/PredicateName: # this creates breaking changes in the API
+Style/MethodMissingSuper: # this doesn't exist in 1.8/1.9
   Enabled: false
-Style/MethodMissing: # this doesn't exist in 1.8/1.9
+Style/MissingRespondToMissing: # this doesn't exist in 1.8/1.9
   Enabled: false
 Style/Lambda: # not supported in 1.8
   Enabled: false
 Style/EachWithObject: # not supported in 1.8
   Enabled: false
-Style/AlignParameters: # does not work correctly with subsequent block
+Layout/ParameterAlignment: # does not work correctly with subsequent block
   Enabled: false
-Style/AlignArray: # does not support indentation
+Layout/ArrayAlignment: # does not support indentation
   Enabled: false
-Style/AlignHash: # does not support indentation
+Layout/HashAlignment: # does not support indentation
   Enabled: false
 Style/MultilineTernaryOperator:
   Enabled: false
 Style/ClassAndModuleChildren:
   Enabled: false
-Style/EmptyLineBetweenDefs:
+Layout/EmptyLineBetweenDefs:
   AllowAdjacentOneLineDefs: true
 Style/SingleLineMethods:
   Enabled: false
@@ -91,9 +89,24 @@ Style/GlobalVars:
   Exclude:
     - benchmarks/**/*.rb
     - spec/**/*.rb
-Lint/UnneededSplatExpansion:
+Lint/RedundantSplatExpansion:
   Enabled: false
-Lint/Eval:
+Security/Eval:
   Exclude:
     - benchmarks/**/*.rb
-- spec/**/*.rb
+    - spec/**/*.rb
+
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: false
+Lint/RaiseException:
+  Enabled: false
+Lint/StructNewOverride:
+  Enabled: false
+Style/ExponentialNotation:
+  Enabled: false
+Style/HashEachMethods:
+  Enabled: false
+Style/HashTransformKeys:
+  Enabled: false
+Style/HashTransformValues:
+  Enabled: false