You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, I'm playing with view_component_storybook in a Rails 5 app that uses the wicked_pdf gem and hitting the clashing-monkey-patches issue with ViewComponent.
Would it make sense to replace #render here with #render_component to allow Storybook to work correctly regardless of whether the VC monkey patch is enabled or disabled?
I'm not sure its quite as simple as that. We'd likely need to detect the monkey patch setting in ViewComponent and do the right thing. Happy to consider a pull request.
Ah! I thought the #render_component method was available either way, but yeah I see now it's only conditionally included after a Rails version check here.
Hi, I'm playing with
view_component_storybook
in a Rails 5 app that uses thewicked_pdf
gem and hitting the clashing-monkey-patches issue with ViewComponent.Would it make sense to replace
#render
here with#render_component
to allow Storybook to work correctly regardless of whether the VC monkey patch is enabled or disabled?https://github.com/jonspalmer/view_component_storybook/blob/baabed807adcb6d51f59f43cbf19db76bdf5a5ee/app/views/view_component/storybook/stories/show.html.erb#L1
Rails 5 compatibility notes here for reference.
The text was updated successfully, but these errors were encountered: