-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FATAL: 1.1.7 to 1.2.0-beta.6 breaks fullscreen mode ('active' of undefined) #396
Comments
I am getting the same error now. But I think the error is coming from the |
I am not sure how to do a pull request, but I think the error is in line 193 of the This:
should be:
like in their examples:
|
Bump. Can we get this merged in? |
Done. Releasing now! Sorry all -- been stressing with some exams coming up. |
Appreciate you @davwheat, thanks for jumping in and getting this merged 🙌🏼 |
Released: |
Steps to reproduce the behavior:
upgrade from 1.1.7 to 1.2.0-beta.6
tested with react 16 and 17!
Expected behavior:
open fullscreen should not throw an error
Actual behavior:
opening fullscreen throws error
Error in function FullScreen in ./node_modules/react-full-screen/dist/index.modern.js:56
🚨 Cannot read property 'active' of undefined 🚨
The text was updated successfully, but these errors were encountered: