Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement sub and jti check #959

Closed
eddy2by4 opened this issue May 31, 2024 · 4 comments · Fixed by #1005
Closed

Implement sub and jti check #959

eddy2by4 opened this issue May 31, 2024 · 4 comments · Fixed by #1005
Labels
good first issue help wanted keep

Comments

@eddy2by4
Copy link

eddy2by4 commented May 31, 2024 •
edited
Loading

Hello,
As per the jwt.org site, our library does not fully support all checks.
https://jwt.io/libraries?language=Python

Do we have a timeline for when sub and jti check might be implemented?

Thanks
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Issues without activity for more than 60 days label Jul 31, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 7, 2024
@jpadilla jpadilla reopened this Aug 7, 2024
@jpadilla jpadilla added help wanted good first issue keep and removed stale Issues without activity for more than 60 days labels Aug 7, 2024
@Divan009 Divan009 mentioned this issue Oct 1, 2024
Closed
@Divan009
Copy link
Contributor

Divan009 commented Oct 2, 2024 •
edited
Loading

@jpadilla I've opened a PR #991 which can close this issue. Do let me know if it needs changes

@eddy2by4
Copy link
Author

eddy2by4 commented Oct 7, 2024 •
edited
Loading

@Divan009 thanks for the great for fixing this issue. The codecoverage test fails though on your PR.
When you have some free time, can you please take a look ?

Thanks again for your contribution !

@Divan009
Copy link
Contributor

Divan009 commented Oct 8, 2024 •
edited
Loading

@jpadilla @eddy2by4 I will write the test cases and fix the issue

Update: Added the Test cases

This was referenced Oct 10, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted keep
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate sub and jti claims for the token Divan009/pyjwt
3 participants
@jpadilla @Divan009 @eddy2by4