Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commitWhenAutocommitDisabled hardwired to true in ManualSchedulerBuilder #287

Open
moreginger opened this issue May 19, 2022 · 1 comment

Comments

@moreginger
Copy link

Is it intentional that commitWhenAutocommitDisabled is hardwired to true in ManualSchedulerBuilder:

final JdbcTaskRepository schedulerTaskRepository = new JdbcTaskRepository(dataSource, true, new DefaultJdbcCustomization(), tableName, taskResolver, new SchedulerName.Fixed("manual"), serializer, clock);

I'm using @Transactional to rollback changes in tests, and this is causing my changes to be committed when I call runAnyDueExecutions.

@kagkarlsson
Copy link
Owner

I have not really thought about it, so no not really intentional. Unsure if there might be any snags if disabling it..
In general ManualScheduler probably has some improvement potential!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants