Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swedish rounding #3

Closed
ScIT-Raphael opened this issue May 19, 2017 · 10 comments
Closed

Swedish rounding #3

ScIT-Raphael opened this issue May 19, 2017 · 10 comments

Comments

@ScIT-Raphael
Copy link

Hi

Thanks for the useful extension! Just have done some first checks in our demo envroiment and have noticed that you not can "Swedish Round" (round to the next 0.05, for example: 2.42 => 2.40 / 2.43 => 2.45).

Is it possible, that you can implement this feature?

Normaly it works over this small code snip:
$betrag = round(($betrag + 0.000001) * 20) / 20;

Best Regards
Raphael

@karliuka
Copy link
Owner

Hi
Thanks, this is an interesting idea. I will try to implement it.

@karliuka
Copy link
Owner

Update the module, please

@ScIT-Raphael
Copy link
Author

Thanks for the modification, it works really well! Is there any possibillity to do this also in the shopping cart?
image

So it should round also the "order total".

@karliuka
Copy link
Owner

Its interesting bug ...

@ScIT-Raphael
Copy link
Author

Do you think you can fix this "bug"?

@karliuka
Copy link
Owner

Fixed. Check, please.

@ScIT-Raphael
Copy link
Author

Guy, you rock! Thanks for fix, works well. Will close this issue/request now - but if you want, pleace create a donation button - would like to spend you something for your work!

@ScIT-Raphael
Copy link
Author

I just allow myself to reopen the thread. I've noted that there is a problem with the calculation, as soon, as you use "display price including taxes". For example: Customer use a product price excl. vat (8%) from 310.19. Now magento 2 shows the customer 335.01 (including tax). Your module rounds the price (310.19 to 310.20, so magento 2 shows the customer 335.02 instead of rounding to 335.00). Can you maybe find a fix for this problem? Thanks for your great work!

@ScIT-Raphael ScIT-Raphael reopened this Jul 23, 2017
@karliuka
Copy link
Owner

Ok, i will try.

@maderlock
Copy link

Just so you know, I didn't recognise the term "Swedish Rounding". I think that most of the world knows this as "Cash Rounding"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants