Skip to content

Commit d27e86a

Browse files
AMoo-Mikiananzh
authored and
kavilla
committed
Add support for Node.js >=14.20.1 <19 (opensearch-project#4071)
* Bump Node.js requirements to 18 Signed-off-by: Miki <miki@amazon.com> * Replace `lmdb-store` with `lmdb` Signed-off-by: Miki <miki@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> * Bump `elastic-apm-node` to the latest minor Signed-off-by: Miki <miki@amazon.com> * Replace webpack and plugins with a patched version that uses xxhash64 * Use `xxhash64` as the hashing algorithm of webpack * Upgrade `globby` * Remove `fibers` Signed-off-by: Miki <miki@amazon.com> * Replace `fs.rmdir` with `fs.rm` in cross-platform tests Signed-off-by: Miki <miki@amazon.com> * Increase listener limit Signed-off-by: Miki <miki@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> * Add promise-stripping serializer Signed-off-by: Miki <miki@amazon.com> * Bump heap for CI Signed-off-by: Miki <miki@amazon.com> * Correct use of fs/promises in @osd/pm Signed-off-by: Miki <miki@amazon.com> * Use fs/promise in plugin post-install cleanup Signed-off-by: Miki <miki@amazon.com> * Set the test server's host to `0.0.0.0` Signed-off-by: Miki <miki@amazon.com> * Sync `.node-version` file Signed-off-by: Miki <miki@amazon.com> * Support both `isPrimary`, for Node 18, and `isMaster`, for Node 14 Signed-off-by: Miki <miki@amazon.com> * Add types when using `isDeepStrictEqual` Signed-off-by: Miki <miki@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> * Add names to `SchemaError` to log more specific errors Signed-off-by: Miki <miki@amazon.com> * Fix failing vega visualization tests outside the CI Signed-off-by: Miki <miki@amazon.com> * Fix snapshot of errors thrown for undefined accessors Signed-off-by: Miki <miki@amazon.com> * Fix flakiness of log_rotator Signed-off-by: Miki <miki@amazon.com> * Fix asynchronous `fs` usafe in plugin discover Signed-off-by: Miki <miki@amazon.com> * Fix mocks in @osd/optimizer Signed-off-by: Miki <miki@amazon.com> * Fix memory leaks caused by setting states on unloaded components Signed-off-by: Miki <miki@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> * Bump Node in Dockerfile Signed-off-by: Miki <miki@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> * Remove the response `close` event as an indicator of the requesting finishing opensearch-project#3601 (comment) Signed-off-by: Miki <miki@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> * [BWC] Timeout after 3 mins of waiting for OSD to be running in tests Signed-off-by: Miki <miki@amazon.com> * Make build use the same node version that tests are run against Signed-off-by: Miki <miki@amazon.com> * Make Node resolve DNS by IPv4 first * This is helpful to resolve `locahost` to `127.0.0.1` Signed-off-by: Miki <miki@amazon.com> * Standardize patterns used by plugin discovery * Enhance absolute path serialization on Windows Signed-off-by: Miki <amoo_miki@yahoo.com> * Mock fetch in SenseEditor tests Signed-off-by: Miki <amoo_miki@yahoo.com> * Restore node-sass usage to fix build performance * `sass-loader@10` is the last version that supports webpack@4 * `sass` is extremely slow when using the legacy API (`render`) and to use the "Modern API" (`compileStringAsync`), `sass-loader@13` would be needed. * The performance of `sass@10` is made acceptable only with `fibers` but that is deprecated and doesn't work on Node 18 Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Miki <miki@amazon.com> * Revert "[CI] setup Chrome and utilize binary path (opensearch-project#3997)" This reverts commit 0188d05 Signed-off-by: Miki <miki@amazon.com> * Prevent fast-fail while running functional test in CI Signed-off-by: Miki <miki@amazon.com> * Revert "Temporarily hardcode chromedriver to 112.0.0 to enable all ftr tests (opensearch-project#3976)" This reverts commit 5ea0cbe. Signed-off-by: Miki <miki@amazon.com> * Save Cypress results artifacts during CI Signed-off-by: Miki <miki@amazon.com> * Add missing required dependency on `set-value` * Also force all to ^4.1.0 due to a vulnerability fixed in 3.1.0. Signed-off-by: Miki <miki@amazon.com> * Prevent multiple calls to bootstrap's shutdown Signed-off-by: Miki <miki@amazon.com> * Use Node 18.16.0 in distributions * Bump jest-canvas-mock to fix failing tests * Extend Node engines versions Signed-off-by: Miki <miki@amazon.com> * Normalize test snapshots across Node 14, 16, and 18 Signed-off-by: Miki <miki@amazon.com> * Update CHANGELOG for Node.js >=14.20.1 <19 support Signed-off-by: Miki <miki@amazon.com> --------- Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com>
1 parent 1c09ca6 commit d27e86a

File tree

78 files changed

+4328
-3882
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

78 files changed

+4328
-3882
lines changed

‎.github/workflows/build_and_test_workflow.yml

+5-20
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,13 @@ env:
2525
TEST_OPENSEARCH_TRANSPORT_PORT: 9403
2626
TEST_OPENSEARCH_PORT: 9400
2727
OSD_SNAPSHOT_SKIP_VERIFY_CHECKSUM: true
28-
# Version 112.0.5615.0
29-
CHROME_VERSION: 1109208
28+
NODE_OPTIONS: "--max-old-space-size=6144 --dns-result-order=ipv4first"
3029

3130
jobs:
3231
build-lint-test:
3332
name: Build and Verify on ${{ matrix.name }}
3433
strategy:
34+
fail-fast: false
3535
matrix:
3636
os: [ubuntu-latest, windows-latest]
3737
include:
@@ -137,22 +137,6 @@ jobs:
137137
steps:
138138
- run: echo Running functional tests for ciGroup${{ matrix.group }}
139139

140-
- name: Setup Chrome
141-
id: setup-chrome
142-
uses: browser-actions/setup-chrome@v1
143-
with:
144-
chrome-version: ${{ env.CHROME_VERSION }}
145-
146-
- name: Set Chrome Path
147-
if: matrix.os != 'windows-latest'
148-
run: |
149-
echo "TEST_BROWSER_BINARY_PATH=${{ steps.setup-chrome.outputs.chrome-path }}" >> $GITHUB_ENV
150-
151-
- name: Set Chrome Path (Windows)
152-
if: matrix.os == 'windows-latest'
153-
run: |
154-
echo "TEST_BROWSER_BINARY_PATH=${{ steps.setup-chrome.outputs.chrome-path }}" >> $env:GITHUB_ENV
155-
156140
- name: Configure git's autocrlf (Windows only)
157141
if: matrix.os == 'windows-latest'
158142
run: |
@@ -403,6 +387,7 @@ jobs:
403387
with:
404388
name: ${{ matrix.version }}-test-failures
405389
path: |
406-
./artifacts/bwc_tmp/test/cypress/videos/without-security/*
407-
./artifacts/bwc_tmp/test/cypress/screenshots/without-security/*
390+
./artifacts/bwc_tmp/test/cypress/videos/*
391+
./artifacts/bwc_tmp/test/cypress/screenshots/*
392+
./artifacts/bwc_tmp/test/cypress/results/*
408393
retention-days: 1

‎.node-version

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
14.21.3
1+
18.16.0

‎.nvmrc

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
14.21.3
1+
18.16.0

‎CHANGELOG.md

+8
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,11 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
2828
- [VisBuilder] Add metric to metric, bucket to bucket aggregation persistence ([#3495](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3495))
2929
- [VisBuilder] Add UI actions handler ([#3732](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3732))
3030
- [VisBuilder] Add persistence to visualizations inner state ([#3751](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3751))
31+
- Add satisfaction survey link to help menu ([#3676] (https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3676))
32+
- [Vis Builder] Add persistence to visualizations inner state ([#3751](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3751))
33+
- [Table Visualization] Move format table, consolidate types and add unit tests ([#3397](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3397))
34+
- [Multiple Datasource] Support Amazon OpenSearch Serverless ([#3957](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3957))
35+
- Add support for Node.js >=14.20.1 <19 ([#4071](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4071))
3136

3237
### 🐛 Bug Fixes
3338

@@ -89,6 +94,9 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
8994

9095
- Update caniuse to `1.0.30001460` to fix failed integration tests ([#3538](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3538))
9196
- [Tests] Fix unit tests for `get_keystore` ([#3854](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3854))
97+
- [Tests] Use `scripts/use_node` instead of `node` in functional test plugins ([#3783](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3783))
98+
99+
## [2.x]
92100

93101
## [2.6.0]
94102

‎Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
ARG NODE_VERSION=14.20.1
1+
ARG NODE_VERSION=18.16.0
22
FROM node:${NODE_VERSION} AS base
33

44
ENV HOME '.'

‎package.json

+10-8
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
"test:jest:ci": "scripts/use_node scripts/jest --ci --colors --runInBand",
4848
"test:jest:ci:coverage": "scripts/use_node scripts/jest --ci --colors --runInBand --coverage",
4949
"test:jest_integration": "scripts/use_node scripts/jest_integration",
50-
"test:jest_integration:ci": "scripts/use_node scripts/jest_integration --ci --colors --max-old-space-size=5120",
50+
"test:jest_integration:ci": "scripts/use_node scripts/jest_integration --ci --colors",
5151
"test:mocha": "scripts/use_node scripts/mocha",
5252
"test:mocha:coverage": "yarn nyc --reporter=text-summary --reporter=lcov --report-dir=./target/opensearch-dashboards-coverage/mocha scripts/use_node scripts/mocha",
5353
"test:ftr": "scripts/use_node scripts/functional_tests",
@@ -79,7 +79,7 @@
7979
"url": "https://github.com/opensearch-project/opensearch-dashboards.git"
8080
},
8181
"resolutions": {
82-
"**/@types/node": "^14.17.32",
82+
"**/@types/node": "~18.7.0",
8383
"**/ansi-regex": "^5.0.1",
8484
"**/async": "^3.2.3",
8585
"**/d3-color": "^3.1.0",
@@ -99,6 +99,7 @@
9999
"**/minimatch": "^3.0.5",
100100
"**/jest-config": "npm:@amoo-miki/jest-config@27.5.1",
101101
"**/jest-jasmine2": "npm:@amoo-miki/jest-jasmine2@27.5.1",
102+
"**/set-value": "^4.1.0",
102103
"**/xml2js": "^0.5.0",
103104
"**/yaml": "^2.2.2"
104105
},
@@ -170,7 +171,7 @@
170171
"deep-freeze-strict": "^1.1.1",
171172
"del": "^6.1.1",
172173
"dns-sync": "^0.2.1",
173-
"elastic-apm-node": "^3.7.0",
174+
"elastic-apm-node": "^3.43.0",
174175
"elasticsearch": "^16.7.0",
175176
"http-aws-es": "npm:@zhongnansu/http-aws-es@6.0.1",
176177
"execa": "^4.0.2",
@@ -180,7 +181,7 @@
180181
"getos": "^3.2.1",
181182
"glob": "^7.1.7",
182183
"glob-all": "^3.2.1",
183-
"globby": "^8.0.1",
184+
"globby": "^11.1.0",
184185
"handlebars": "4.7.7",
185186
"hjson": "3.2.1",
186187
"http-proxy-agent": "^2.1.0",
@@ -215,6 +216,7 @@
215216
"rison-node": "1.0.2",
216217
"rxjs": "^6.5.5",
217218
"semver": "^5.7.0",
219+
"set-value": "^4.1.0",
218220
"source-map-support": "^0.5.19",
219221
"symbol-observable": "^1.2.0",
220222
"tar": "^6.1.11",
@@ -305,7 +307,7 @@
305307
"@types/mock-fs": "^4.10.0",
306308
"@types/moment-timezone": "^0.5.12",
307309
"@types/mustache": "^0.8.31",
308-
"@types/node": "^14.17.32",
310+
"@types/node": "~18.7.0",
309311
"@types/node-forge": "^1.0.1",
310312
"@types/normalize-path": "^3.0.0",
311313
"@types/pegjs": "^0.10.1",
@@ -400,7 +402,7 @@
400402
"immer": "^9.0.6",
401403
"intl-messageformat-parser": "^1.4.0",
402404
"jest": "^27.5.1",
403-
"jest-canvas-mock": "^2.3.1",
405+
"jest-canvas-mock": "^2.5.1",
404406
"jest-raw-loader": "^1.0.1",
405407
"jimp": "^0.14.0",
406408
"jquery": "^3.5.0",
@@ -473,7 +475,7 @@
473475
"zlib": "^1.0.5"
474476
},
475477
"engines": {
476-
"node": "^14.20.1",
477-
"yarn": "^1.21.1"
478+
"node": ">=14.20.1 <19",
479+
"yarn": "^1.22.10"
478480
}
479481
}

‎packages/osd-ace/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,6 @@
1616
"@osd/babel-preset": "1.0.0",
1717
"raw-loader": "^4.0.2",
1818
"typescript": "4.0.2",
19-
"webpack": "^4.41.5"
19+
"webpack": "npm:@amoo-miki/webpack@4.46.0-rc.2"
2020
}
2121
}

‎packages/osd-config-schema/src/errors/__snapshots__/schema_error.test.ts.snap

+2-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/osd-config-schema/src/errors/schema_error.test.ts

+10-2
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,14 @@ import { SchemaError } from '.';
3333

3434
import { standardize, getRepoRoot } from '@osd/cross-platform';
3535

36+
// ToDo: Remove this logic when Node 14 support is removed
37+
const isNode14 = process.version.startsWith('v14.');
38+
3639
/**
3740
* Make all paths in stacktrace relative.
3841
*/
39-
export const cleanStack = (stack: string) =>
40-
stack
42+
export const cleanStack = (stack: string) => {
43+
const result = stack
4144
.split('\n')
4245
.filter((line) => !line.includes('node_modules' + sep) && !line.includes('internal/'))
4346
.map((line) => {
@@ -54,6 +57,11 @@ export const cleanStack = (stack: string) =>
5457
})
5558
.join('\n');
5659

60+
return isNode14
61+
? result.replace(/Error:\s([^\n]+)\n\s*at new ([^ ]+) [^\n]*\n/, '$2: $1\n')
62+
: result;
63+
};
64+
5765
it('includes stack', () => {
5866
try {
5967
throw new SchemaError('test');

‎packages/osd-config-schema/src/errors/schema_error.ts

+1
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ export class SchemaError extends Error {
3434
constructor(message: string, cause?: Error) {
3535
super(message);
3636
this.cause = cause;
37+
this.name = this.constructor.name;
3738

3839
// Set the prototype explicitly, see:
3940
// https://github.com/Microsoft/TypeScript/wiki/Breaking-Changes#extending-built-ins-like-error-array-and-map-may-no-longer-work

‎packages/osd-config/src/config_service.test.ts

+9-9
Original file line numberDiff line numberDiff line change
@@ -94,10 +94,10 @@ test('throws if config at path does not match schema', async () => {
9494
);
9595

9696
await expect(valuesReceived).toMatchInlineSnapshot(`
97-
Array [
98-
[Error: [config validation of [key]]: expected value of type [string] but got [number]],
99-
]
100-
`);
97+
Array [
98+
[ValidationError: [config validation of [key]]: expected value of type [string] but got [number]],
99+
]
100+
`);
101101
});
102102

103103
test('re-validate config when updated', async () => {
@@ -120,11 +120,11 @@ test('re-validate config when updated', async () => {
120120
rawConfig$.next({ key: 123 });
121121

122122
await expect(valuesReceived).toMatchInlineSnapshot(`
123-
Array [
124-
"value",
125-
[Error: [config validation of [key]]: expected value of type [string] but got [number]],
126-
]
127-
`);
123+
Array [
124+
"value",
125+
[ValidationError: [config validation of [key]]: expected value of type [string] but got [number]],
126+
]
127+
`);
128128
});
129129

130130
test("returns undefined if fetching optional config at a path that doesn't exist", async () => {

‎packages/osd-cross-platform/src/path.test.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
import path from 'path';
77
import fs from 'fs';
8-
import { access, rmdir, mkdir, writeFile, symlink } from 'fs/promises';
8+
import { access, rm, mkdir, writeFile, symlink } from 'fs/promises';
99

1010
import {
1111
resolveToFullNameSync,
@@ -43,9 +43,9 @@ describe('Cross Platform', () => {
4343
try {
4444
// If leftover artifacts were found, get rid of them
4545
await access(tmpTestFolder);
46-
await rmdir(tmpTestFolder, { recursive: true });
46+
await rm(tmpTestFolder, { recursive: true });
4747
} catch (ex) {
48-
// Do nothing; if `rmdir` failed, let the `mkdir` below throw the error
48+
// Do nothing; if `rm` failed, let the `mkdir` below throw the error
4949
}
5050

5151
await mkdir(tmpTestFolder);
@@ -60,7 +60,7 @@ describe('Cross Platform', () => {
6060

6161
afterAll(async () => {
6262
try {
63-
await rmdir(tmpTestFolder, { recursive: true });
63+
await rm(tmpTestFolder, { recursive: true });
6464
} catch (ex) {
6565
// Do nothing
6666
}

‎packages/osd-dev-utils/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"execa": "^4.0.2",
2323
"exit-hook": "^2.2.0",
2424
"getopts": "^2.2.5",
25-
"globby": "^8.0.1",
25+
"globby": "^11.1.0",
2626
"load-json-file": "^6.2.0",
2727
"markdown-it": "^12.3.2",
2828
"moment": "^2.24.0",

‎packages/osd-dev-utils/src/proc_runner/proc.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -153,15 +153,15 @@ export function startProc(name: string, options: ProcOptions, log: ToolingLog) {
153153
await withTimeout(
154154
async () => {
155155
log.debug(`Sending "${signal}" to proc "${name}"`);
156-
await treeKillAsync(childProcess.pid, signal);
156+
await treeKillAsync(childProcess.pid!, signal);
157157
await outcomePromise;
158158
},
159159
STOP_TIMEOUT,
160160
async () => {
161161
log.warning(
162162
`Proc "${name}" was sent "${signal}" didn't emit the "exit" or "error" events after ${STOP_TIMEOUT} ms, sending SIGKILL`
163163
);
164-
await treeKillAsync(childProcess.pid, 'SIGKILL');
164+
await treeKillAsync(childProcess.pid!, 'SIGKILL');
165165
}
166166
);
167167

‎packages/osd-dev-utils/src/serializers/absolute_path_serializer.ts

+4
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,10 @@ export function createAbsolutePathSerializer(
3737
) {
3838
const rootPaths = Array.isArray(rootPath) ? rootPath : [rootPath];
3939

40+
if (process.platform === 'win32') {
41+
rootPaths.push(...rootPaths.map((name) => name.replace(/\\/g, '/')));
42+
}
43+
4044
return {
4145
test: (value: any) =>
4246
typeof value === 'string' && rootPaths.some((path) => value.startsWith(path)),

‎packages/osd-dev-utils/src/serializers/index.ts

+1
Original file line numberDiff line numberDiff line change
@@ -33,3 +33,4 @@ export * from './strip_ansi_serializer';
3333
export * from './recursive_serializer';
3434
export * from './any_instance_serizlizer';
3535
export * from './replace_serializer';
36+
export * from './strip_promises_serizlizer';

‎packages/osd-dev-utils/src/serializers/strip_promises_serizlizer.ts

+9
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
/*
2+
* Copyright OpenSearch Contributors
3+
* SPDX-License-Identifier: Apache-2.0
4+
*/
5+
6+
export const createStripPromisesSerializer = () => ({
7+
serialize: (value: string) => value.replace(/("value": Promise) \{[^}]+}/gm, '$1 {}'),
8+
test: (value: any) => typeof value === 'string',
9+
});

‎packages/osd-dev-utils/src/simple_opensearch_dashboards_platform_plugin_discovery.ts

+13-13
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@
2828
* under the License.
2929
*/
3030

31-
import Path from 'path';
31+
import { resolve } from 'path';
32+
import { standardize } from '@osd/cross-platform';
3233

3334
import globby from 'globby';
3435

@@ -47,24 +48,23 @@ export function simpleOpenSearchDashboardsPlatformPluginDiscovery(
4748
...scanDirs.reduce(
4849
(acc: string[], dir) => [
4950
...acc,
50-
Path.resolve(dir, '*/opensearch_dashboards.json'),
51-
Path.resolve(dir, '*/*/opensearch_dashboards.json'),
52-
Path.resolve(dir, '*/*/*/opensearch_dashboards.json'),
53-
Path.resolve(dir, '*/*/*/*/opensearch_dashboards.json'),
54-
Path.resolve(dir, '*/*/*/*/*/opensearch_dashboards.json'),
51+
resolve(dir, '*/opensearch_dashboards.json'),
52+
resolve(dir, '*/*/opensearch_dashboards.json'),
53+
resolve(dir, '*/*/*/opensearch_dashboards.json'),
54+
resolve(dir, '*/*/*/*/opensearch_dashboards.json'),
55+
resolve(dir, '*/*/*/*/*/opensearch_dashboards.json'),
5556
],
5657
[]
5758
),
58-
...pluginPaths.map((path) => Path.resolve(path, `opensearch_dashboards.json`)),
59+
...pluginPaths.map((path) => resolve(path, `opensearch_dashboards.json`)),
5960
])
6061
);
6162

62-
const manifestPaths = globby.sync(patterns, { absolute: true }).map((path) =>
63-
// absolute paths returned from globby are using normalize or
64-
// something so the path separators are `/` even on windows,
65-
// Path.resolve solves this
66-
Path.resolve(path)
67-
);
63+
const standardizedPatterns = patterns.map((pattern) => standardize(pattern));
64+
65+
const manifestPaths = globby
66+
.sync(standardizedPatterns, { absolute: true })
67+
.map((path) => standardize(resolve(path)));
6868

6969
return manifestPaths.map(parseOpenSearchDashboardsPlatformPlugin);
7070
}

‎packages/osd-eslint-import-resolver-opensearch-dashboards/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,6 @@
1919
"glob-all": "^3.2.1",
2020
"lru-cache": "^4.1.5",
2121
"resolve": "^1.7.1",
22-
"webpack": "^4.41.5"
22+
"webpack": "npm:@amoo-miki/webpack@4.46.0-rc.2"
2323
}
2424
}

0 commit comments

Comments
 (0)