Skip to content

Commit b7af315

Browse files
Fix rocoto forecast hour determination for GEFS (NOAA-EMC#2351)
The function that generates the list of forecast hours for rocoto was trying to use variables that are not defined for GEFS, causing workflow generation to fail. The function is updated to not try to load these variables before loading the ones actually used for GFS/ GEFS. Also turns GEFS CI test back on and adds an entry to stage C192 ICs (note: these have not been placed in the centralized location.)
1 parent d3a4927 commit b7af315

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed

ci/cases/pr/C48_S2SWA_gefs.yaml

-5
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,3 @@ arguments:
1616
idate: 2021032312
1717
edate: 2021032312
1818
yaml: {{ HOMEgfs }}/ci/cases/yamls/gefs_ci_defaults.yaml
19-
20-
skip_ci_on_hosts:
21-
- hera
22-
- orion
23-
- hercules

parm/config/gfs/config.stage_ic

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ echo "BEGIN: config.stage_ic"
88
source "${EXPDIR}/config.resources" stage_ic
99

1010
case "${CASE}" in
11-
"C48" | "C96")
11+
"C48" | "C96" | "C192")
1212
export CPL_ATMIC="workflow_${CASE}_refactored"
1313
export CPL_ICEIC="workflow_${CASE}_refactored"
1414
export CPL_OCNIC="workflow_${CASE}_refactored"

workflow/rocoto/tasks.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -132,12 +132,12 @@ def _get_forecast_hours(cdump, config, component='atmos') -> List[str]:
132132
local_config['FHOUT'] = config['FHOUT_OCNICE']
133133

134134
fhmin = local_config['FHMIN']
135-
fhmax = local_config['FHMAX']
136-
fhout = local_config['FHOUT']
137135

138136
# Get a list of all forecast hours
139137
fhrs = []
140138
if cdump in ['gdas']:
139+
fhmax = local_config['FHMAX']
140+
fhout = local_config['FHOUT']
141141
fhrs = list(range(fhmin, fhmax + fhout, fhout))
142142
elif cdump in ['gfs', 'gefs']:
143143
fhmax = local_config['FHMAX_GFS']

0 commit comments

Comments
 (0)