-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kedro-viz needs too much to run properly #1159
Comments
+1 that this is annoying. I remember in the past, when had nodes with hard-to-install dependencies (e.g. a node that called R code using What I recall:
|
Transferred this issue to the Kedro-Viz repo, because it's not framework related. |
Hi @foxale, Unfortunately I don't have a solution to your problem better than "turn off the mlflow hook". I feel a bit responsible about this issue, both because I am the maintainer of the kedro-mlflow plugin, and because the root cause of this is due to a bunch of issues and suggestions I made to the core framework. I will try to explain what's going on here and the rationale behind this behaviour. In these issues: kedro-org/kedro#506 and kedro-org/kedro#1431, there was a huge discussion about enabling hooks to access the After these discussion we decided to introduce an The main advantage of creating connection after context creation is that when you are using the session interactively (in a script of a jupyter notebook), this is done automatically: you don't have to setup manually all connections. On the other hand, the biggest drawback is that this connection is always instantiated, including when calling Maybe @noklam or @AntonyMilneQB of the core team can add furhter help, and eventually suggest a solution ? |
@foxale Thank you for your question. The answer to that is pretty much covered. tl;dr
|
Well, it still looks like a fixable problem on the |
@foxale would you feel comfortable opening a PR that tries to solve this problem? We'd certainly appreciate it, as we welcome any and all contributions from the community! |
This is certainly doable if the team thinks we should do this. It's not the most elegant solution you can find, but I think simply do something like if SOME_FLAG:
session._hook_manager = _NullPluginManager()
# Before this line
context = session.load_context() This will remove all the hooks and should avoid this problem. kedro-viz/package/kedro_viz/integrations/kedro/data_loader.py Lines 72 to 91 in cc11edb
|
Potential solution for this: #1459 (comment) |
Reopening this issue, as there's some issues around working with Spark that |
Hi @foxale , We implemented a possible solution here which mocks missing dependencies. This will be merged in the upcoming Kedro-Viz release. I know it is a long overdue ticket, but it is finally ready :D . I hope this will resolve the dependency problems. Try running |
Hi @foxale , Could you please let us know if you have used |
Closing this issue as we have some solutions to run kedro-viz easily such as |
Description
So according to this #1125 kedro-viz requires
For me it just doesn't make sense. Why would I need to have the python env ready to visualize project flow? The original issue seems dead, but kedro-viz is still in some way a core kedro feature, so..
The text was updated successfully, but these errors were encountered: