Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing KedroContext params and catalog hot-reload #1460

Open
Tracked by #1441
noklam opened this issue Apr 20, 2022 · 0 comments
Open
Tracked by #1441

Removing KedroContext params and catalog hot-reload #1460

noklam opened this issue Apr 20, 2022 · 0 comments

Comments

@noklam
Copy link
Contributor

noklam commented Apr 20, 2022

Description

Remove the hot-reloading behaviour of params and catalog in favour of using the Ipython reload kedro magic. It will further clear up the responsibility of KedroContext as a dataclass, and the logic of creating them will be moved to session instead. by @idanov

Context

This work is part of the clean of up KedroContext, which was made into a dataclass in: #1465. KedroContext should merely be a container and not have any "advanced" logic or responsibility. Any instance creation etc. should be happening in KedroSession instead.

The hot-reloading of params and catalog is mainly useful for the interactive workflow, but reload kedro can achieve the same thing and so that should be the recommended way instead.

User problem

When users make changes in parameters.yml or catalog.yml and they're working in a Jupyter notebook, then they have to do %reload_kedro to see those changes reflected in their Jupyter notebook. This behaviour is not the same as when you run session.catalog in a notebook. We should make consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants