-
Notifications
You must be signed in to change notification settings - Fork 936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pass globals as context to jinja2 template #1532
Comments
Hi @shaunc your problem and solution are very valid, but we're not in a place to accept this just yet. A couple of weeks I pitched a bit of a duct-tape fix that would open this up, but we as a maintainer group came to the conclusion that it was too risky for us to implement. The discussion on the PR is also relevant. The main risks stem from a couple of major points:
I appreciate my answer is also a little frustrating, to solve your problem today the best alternative I can suggest is defining a custom |
You could slip it in and maybe no one would notice? :) [ok .. adding thoughts to bottom of the design discussion.] |
Response for reference: #891 (comment) |
Hi @shaunc, thanks for raising this issue and sharing your thoughts in the user research synthesis issue as well! Echoing @datajoely here: this problem is very valid and improving configuration in Kedro is a high priority for the team. However, as you probably figured from the long conversation on the research piece, it's far from trivial and we want to make sure if we do an overhaul of how configuration works, we do it well and serve our users' needs properly. Improving the ways of working with For the time being, I'd suggest you do what Joel said and create a custom config loader that suits your use case best. If it's alright with you, I'll close your related PR for now, and we can continue the discuss this issue here. We really appreciate your feedback and ideas on how to improve Kedro! |
Description
When configuring with jinja2 templates, I don't want variables embedded in templates as a source of authority.
Therefore, I have threaded through globals dict as context for configuration templates.
Context
Make jinja2 templates for configuration more maintainable.
Possible Implementation
#1542
The text was updated successfully, but these errors were encountered: