Skip to content

Commit ef966aa

Browse files
authored
chore: bump minimum node version to 12, npm 6.9 (appium#15000)
1 parent 024aab3 commit ef966aa

File tree

6 files changed

+23
-17
lines changed

6 files changed

+23
-17
lines changed

.github/workflows/node.js.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111

1212
strategy:
1313
matrix:
14-
node-version: [10.x, 12.x, 14.x]
14+
node-version: [12.x, 14.x]
1515

1616
steps:
1717
- uses: actions/checkout@v2

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ Concepts](/docs/en/about-appium/intro.md).
5858
Your environment needs to be set up for the particular platforms that you want
5959
to run tests on. Each of the drivers above documents the requirements for their
6060
particular brand of automation. At a minimum, you will need to be able to run
61-
Node.js 10+.
61+
Node.js 12+.
6262

6363
### Get Started
6464

ci-jobs/update-appium-io.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
steps:
1010
- task: NodeTool@0
1111
inputs:
12-
versionSpec: '10.x'
12+
versionSpec: '14.x'
1313
- script: |
1414
pip install mkdocs==0.16.3
1515
git config --global user.email "maintainers@appium.io"
@@ -28,4 +28,4 @@ jobs:
2828
popd
2929
displayName: Make branch with Updated Docs and make PR
3030
env:
31-
GITHUB_TOKEN: $(GITHUB_TOKEN)
31+
GITHUB_TOKEN: $(GITHUB_TOKEN)

docs/README.md

+7-2
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,11 @@ Formatted doc is [here](http://appium.io/documentation.html?lang=en).
66

77
## doc translation
88

9-
At the moment we are focusing on improving the english documentation. When it
10-
is done we are planning to setup proper i18n l10n processes so that it is
9+
At the moment we are focusing on improving the english documentation. When it
10+
is done we are planning to setup proper i18n l10n processes so that it is
1111
easier for people to help in translating the documentation.
12+
13+
## Bump supported NodeJS version
14+
15+
- Refer to https://nodejs.org/en/download/releases/ if current supported version is EOL
16+
- Example to bump supported NodeJS version: https://github.com/appium/appium/pull/15000

package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222
"url": "https://github.com/appium/appium/issues"
2323
},
2424
"engines": {
25-
"node": ">=8",
26-
"npm": ">=6"
25+
"node": ">=12",
26+
"npm": ">=6.9"
2727
},
2828
"main": "./build/lib/main.js",
2929
"bin": {

test/config-specs.js

+10-9
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,8 @@ describe('Config', function () {
145145
describe('unsupported nodes', function () {
146146
const unsupportedVersions = [
147147
'v0.1', 'v0.9.12', 'v0.10.36', 'v0.12.14',
148-
'v4.4.7', 'v5.7.0', 'v6.3.1', 'v7.1.1',
148+
'v4.4.7', 'v5.7.0', 'v6.3.1', 'v7.1.1', 'v8.1.2',
149+
'v9.1.2', 'v10.0.1', 'v11.6.0'
149150
];
150151
for (const version of unsupportedVersions) {
151152
it(`should fail if node is ${version}`, function () {
@@ -156,20 +157,20 @@ describe('Config', function () {
156157
});
157158

158159
describe('supported nodes', function () {
159-
it('should succeed if node is 8+', function () {
160-
process.version = 'v8.1.2';
160+
it('should succeed if node is 12+', function () {
161+
process.version = '12.20.1';
161162
checkNodeOk.should.not.throw();
162163
});
163-
it('should succeed if node is 9+', function () {
164-
process.version = 'v9.1.2';
164+
it('should succeed if node is 13+', function () {
165+
process.version = '13.14.0';
165166
checkNodeOk.should.not.throw();
166167
});
167-
it('should succeed if node is 10+', function () {
168-
process.version = 'v10.0.1';
168+
it('should succeed if node is 14+', function () {
169+
process.version = '14.15.4';
169170
checkNodeOk.should.not.throw();
170171
});
171-
it('should succeed if node is 11+', function () {
172-
process.version = 'v11.6.0';
172+
it('should succeed if node is 15+', function () {
173+
process.version = '15.5.1';
173174
checkNodeOk.should.not.throw();
174175
});
175176
});

0 commit comments

Comments
 (0)