Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom kodataRoot and kodata per image #54

Closed
xmlking opened this issue Jul 8, 2019 · 4 comments
Closed

custom kodataRoot and kodata per image #54

xmlking opened this issue Jul 8, 2019 · 4 comments

Comments

@xmlking
Copy link
Contributor

xmlking commented Jul 8, 2019

proposing to support customizing kodataRoot per image level. currently it is hardcoded at /var/run/ko

const kodataRoot = "/var/run/ko"

also would be nice to allow developers to keep kodata in any prefered directory relative to source root.
this allow to keep per module kodata folder in monorepo projects that represent multiple sub modules

@xmlking xmlking changed the title custom const kodataRoot and kodata in project source custom kodataRoot and kodata per image Jul 8, 2019
@jonjohnsonjr
Copy link
Collaborator

Somewhat related #55

@mschwrz
Copy link
Contributor

mschwrz commented Jul 9, 2019

Can you make a suggestion on how to supply the custom kodataRoot?

@xmlking
Copy link
Contributor Author

xmlking commented Jul 10, 2019

here is the proposal for copying multiple source directories to image

baseImageOverrides:
  github.com/my-org/my-repo/path/to/binary: docker.io/another/base:latest
buildOverrides:
  github.com/my-org/my-repo/path/to/binary:
    env:
    - name: CGO_ENABLED
      value: 1
    flags:
    - name: ldflags
      value: "-X main.Version=foo"
    data:
    - source: "config/template"
      destination: "template"
    - source: "config/seed"
      destination: "data/seed"

destination is relative to WorkingDir
source is relative to PrtojectRoot

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants