Fix desktop app crash without profile picture

bancek · bancek · commit b24c640218d1 · 2024-06-21T14:57:32.000+02:00
diff --git a/vault-web/src/desktopVault/WebVaultClient.ts b/vault-web/src/desktopVault/WebVaultClient.ts
@@ -64,6 +64,10 @@ export class WebVaultClient {
   }
 
   handleResponse(request: XMLHttpRequest, bytes: boolean) {
+    if (request.status === 204) {
+      return undefined;
+    }
+
     const { body } = this.requestEncryption.decryptResponse(
       request.responseText,
     );
@@ -72,10 +76,6 @@ export class WebVaultClient {
       throw new Error(`Call error: ${request.status}: ${body}`);
     }
 
-    if (request.status === 204) {
-      return undefined;
-    }
-
     if (bytes) {
       return new Uint8Array(decode(body));
     }

Original file line number	Diff line number	Diff line change
`@@ -64,6 +64,10 @@ export class WebVaultClient {`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`handleResponse(request: XMLHttpRequest, bytes: boolean) {`
	`67`	`+ if (request.status === 204) {`
	`68`	`+ return undefined;`
	`69`	`+ }`
	`70`	`+`
`67`	`71`	`const { body } = this.requestEncryption.decryptResponse(`
`68`	`72`	`request.responseText,`
`69`	`73`	`);`
`@@ -72,10 +76,6 @@ export class WebVaultClient {`
`72`	`76`	throw new Error(`Call error: ${request.status}: ${body}`);
`73`	`77`	`}`
`74`	`78`
`75`		`- if (request.status === 204) {`
`76`		`- return undefined;`
`77`		`- }`
`78`		`-`
`79`	`79`	`if (bytes) {`
`80`	`80`	`return new Uint8Array(decode(body));`
`81`	`81`	`}`