Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch GCP Subnetwork from API #1950

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

kgroschoff
Copy link
Contributor

What this PR does / why we need it:
Fetch GCP Subnetworks from API.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to https://github.com/kubermatic/dashboard-v2/issues/1519

Special notes for your reviewer:
/hold
until kubermatic/kubermatic#4997 gets merged

Release note:

Fetch GCP Subnetworks from API

@kgroschoff kgroschoff self-assigned this Jan 30, 2020
@kubermatic-bot kubermatic-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jan 30, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kgroschoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 30, 2020
@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #1950 into master will decrease coverage by 0.26%.
The diff coverage is 21.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1950      +/-   ##
==========================================
- Coverage   69.28%   69.02%   -0.27%     
==========================================
  Files         246      246              
  Lines        8931     9055     +124     
  Branches     1124     1162      +38     
==========================================
+ Hits         6188     6250      +62     
- Misses       2737     2799      +62     
  Partials        6        6
Impacted Files Coverage Δ
...provider-options/gcp-provider-options.component.ts 30.57% <18.6%> (-6.61%) ⬇️
src/app/core/services/api/api.service.ts 35.75% <25%> (-0.27%) ⬇️
src/app/core/services/wizard/provider/gcp.ts 55.76% <27.27%> (-7.65%) ⬇️
src/app/testing/services/api-mock.service.ts 68.14% <50%> (-0.33%) ⬇️
...uster/cluster-details/cluster-details.component.ts 68.84% <0%> (+2.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c3900f...64f2476. Read the comment docs.

@maciaszczykm
Copy link
Contributor

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 30a387daf9ca0e1726682899a681121f89dbf047

@kgroschoff
Copy link
Contributor Author

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2020
@kgroschoff
Copy link
Contributor Author

/test pull-dashboard-e2e

@kubermatic-bot kubermatic-bot merged commit 7cec6aa into kubermatic:master Jan 30, 2020
@kgroschoff kgroschoff deleted the feature/gcp-subnetwork branch January 30, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants