-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch GCP Subnetwork from API #1950
Fetch GCP Subnetwork from API #1950
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kgroschoff The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #1950 +/- ##
==========================================
- Coverage 69.28% 69.02% -0.27%
==========================================
Files 246 246
Lines 8931 9055 +124
Branches 1124 1162 +38
==========================================
+ Hits 6188 6250 +62
- Misses 2737 2799 +62
Partials 6 6
Continue to review full report at Codecov.
|
/lgtm |
LGTM label has been added. Git tree hash: 30a387daf9ca0e1726682899a681121f89dbf047
|
/hold cancel |
/test pull-dashboard-e2e |
What this PR does / why we need it:
Fetch GCP Subnetworks from API.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Related to https://github.com/kubermatic/dashboard-v2/issues/1519
Special notes for your reviewer:
/hold
until kubermatic/kubermatic#4997 gets merged
Release note: