Fix node data dialog for vSphere clusters

[maciaszczykm]

What this PR does / why we need it: The node data dialog doesn't load due to null pointer without it.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #2249.

Special notes for your reviewer: Null pointer is thrown because datacenters switch during the component lifetime. When it is loaded for the first time seed datacenter is used (i.e. europe-west3-c) and it doesn't contain the templates that are used in the component (that's why it rendering fails). Just after that the datacenter is loaded again but this time it's not seed datacenter but the one from the cluster specification (this._dc.getDataCenter(this.cluster.spec.cloud.dc); i.e. vsphere-hamburg). This is an important issue that we have to address sooner than later. Overall, I can see that in few places seed datacenters are mixed with others.

cc @kgroschoff @floreks

Release note:

Fixed node data dialog for vSphere clusters.

[kubermatic-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Merging #2251 into master will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2251      +/-   ##
==========================================
- Coverage   66.68%   66.61%   -0.07%     
==========================================
  Files         275      276       +1     
  Lines       10350    10380      +30     
  Branches     1315     1320       +5     
==========================================
+ Hits         6902     6915      +13     
- Misses       3440     3457      +17     
  Partials        8        8              

Impacted Files	Coverage Δ
src/app/node-data/node-data.component.ts	70.67% <0.00%> (-0.54%)	⬇️
...rc/app/node-data-new/service/provider/openstack.ts	40.74% <0.00%> (ø)
src/app/node-data-new/service/service.ts	73.68% <0.00%> (+0.95%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5225310...2886fc7. Read the comment docs.

[kgroschoff]

👍
Should we also put cherrypick it into 2.14?
/lgtm

[kubermatic-bot]

LGTM label has been added.

Git tree hash: 23e39841c538609a0d6b90f8e7e11114d0a4461f

[maciaszczykm]

@kgroschoff Sure, is there a branch already? I thought that the latest release was from master.

[kgroschoff]

Seems you're right. I just saw the rc and thought that there already is a branch for it. Should have read the whole text before. Forget what I said :D