Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

releaser should fail on replace directives #2549

Closed
monopole opened this issue May 28, 2020 · 2 comments
Closed

releaser should fail on replace directives #2549

monopole opened this issue May 28, 2020 · 2 comments

Comments

@monopole
Copy link
Contributor

when releasing module foo, if a replace directive is found in the go.mod file, e.g.

replace sigs.k8s.io/kustomize/api v0.0.0 => ../../../api

the release script should fail with a warning message like

  • In foo's go.mod, remove replacement of module bar and pin to a specific version of bar.
  • This may require first releasing a new version of bar.

Replace directives allow go build and test to work as multiple modules are developed at the same time, but cannot be left in place at release (git tag) time, as go get and go install won't work at the given tag.

cause of #2462

@monopole monopole changed the title releaser should refuse to tag modules with replace directives releaser should fail on replace directives May 28, 2020
@monopole
Copy link
Contributor Author

@monopole
Copy link
Contributor Author

monopole commented Jun 1, 2020

fixed

@monopole monopole closed this as completed Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant