Merge pull request #156 from IonBazan/bugfix/final-class-reflection

Ocramius · web-flow · commit 91aabc066d56 · 2022-11-21T02:32:31.000+01:00
Fix generating final classes from reflection
diff --git a/src/Generator/ClassGenerator.php b/src/Generator/ClassGenerator.php
@@ -85,6 +85,7 @@ public static function fromReflection(ClassReflection $classReflection)
         }
 
         $cg->setAbstract($classReflection->isAbstract());
+        $cg->setFinal($classReflection->isFinal());
 
         // set the namespace
         if ($classReflection->inNamespace()) {
diff --git a/test/Generator/ClassGeneratorTest.php b/test/Generator/ClassGeneratorTest.php
@@ -1395,7 +1395,7 @@ public function testClassWithPromotedParameterFromReflection(): void
         $expectedOutput = <<<EOS
 namespace LaminasTest\Code\Generator\TestAsset;
 
-class ClassWithPromotedParameter
+final class ClassWithPromotedParameter
 {
     public function __construct(private string \$promotedParameter)
     {

Original file line number	Diff line number	Diff line change
`@@ -85,6 +85,7 @@ public static function fromReflection(ClassReflection $classReflection)`
`85`	`85`	`}`
`86`	`86`
`87`	`87`	`$cg->setAbstract($classReflection->isAbstract());`
	`88`	`+ $cg->setFinal($classReflection->isFinal());`
`88`	`89`
`89`	`90`	`// set the namespace`
`90`	`91`	`if ($classReflection->inNamespace()) {`
Original file line number	Diff line number	Diff line change
`@@ -1395,7 +1395,7 @@ public function testClassWithPromotedParameterFromReflection(): void`
`1395`	`1395`	`$expectedOutput = <<<EOS`
`1396`	`1396`	`namespace LaminasTest\Code\Generator\TestAsset;`
`1397`	`1397`
`1398`		`-class ClassWithPromotedParameter`
	`1398`	`+final class ClassWithPromotedParameter`
`1399`	`1399`	`{`
`1400`	`1400`	`public function __construct(private string \$promotedParameter)`
`1401`	`1401`	`{`