Skip to content

Commit 4e43fe7

Browse files
authored
[1.x] Fix NODE_VERSION on buid. (#274)
If `NODE_VERSION` declared as `ENV` variable and overwritten in `docker-compose.yml`, new value is not available in build.
1 parent 9771aed commit 4e43fe7

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

runtimes/7.4/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@ FROM ubuntu:21.04
33
LABEL maintainer="Taylor Otwell"
44

55
ARG WWWGROUP
6+
ARG NODE_VERSION=16
67

78
WORKDIR /var/www/html
89

910
ENV DEBIAN_FRONTEND noninteractive
1011
ENV TZ=UTC
11-
ENV NODE_VERSION=16
1212

1313
RUN ln -snf /usr/share/zoneinfo/$TZ /etc/localtime && echo $TZ > /etc/timezone
1414

runtimes/8.0/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@ FROM ubuntu:21.04
33
LABEL maintainer="Taylor Otwell"
44

55
ARG WWWGROUP
6+
ARG NODE_VERSION=16
67

78
WORKDIR /var/www/html
89

910
ENV DEBIAN_FRONTEND noninteractive
1011
ENV TZ=UTC
11-
ENV NODE_VERSION=16
1212

1313
RUN ln -snf /usr/share/zoneinfo/$TZ /etc/localtime && echo $TZ > /etc/timezone
1414

runtimes/8.1/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@ FROM ubuntu:21.04
33
LABEL maintainer="Taylor Otwell"
44

55
ARG WWWGROUP
6+
ARG NODE_VERSION=16
67

78
WORKDIR /var/www/html
89

910
ENV DEBIAN_FRONTEND noninteractive
1011
ENV TZ=UTC
11-
ENV NODE_VERSION=16
1212

1313
RUN ln -snf /usr/share/zoneinfo/$TZ /etc/localtime && echo $TZ > /etc/timezone
1414

0 commit comments

Comments
 (0)