Skip to content

Commit c715b72

Browse files
keestorvalds
authored andcommitted
mm: revert x86_64 and arm64 ELF_ET_DYN_BASE base changes
Moving the x86_64 and arm64 PIE base from 0x555555554000 to 0x000100000000 broke AddressSanitizer. This is a partial revert of: eab0953 ("binfmt_elf: use ELF_ET_DYN_BASE only for PIE") 0244599 ("arm64: move ELF_ET_DYN_BASE to 4GB / 4MB") The AddressSanitizer tool has hard-coded expectations about where executable mappings are loaded. The motivation for changing the PIE base in the above commits was to avoid the Stack-Clash CVEs that allowed executable mappings to get too close to heap and stack. This was mainly a problem on 32-bit, but the 64-bit bases were moved too, in an effort to proactively protect those systems (proofs of concept do exist that show 64-bit collisions, but other recent changes to fix stack accounting and setuid behaviors will minimize the impact). The new 32-bit PIE base is fine for ASan (since it matches the ET_EXEC base), so only the 64-bit PIE base needs to be reverted to let x86 and arm64 ASan binaries run again. Future changes to the 64-bit PIE base on these architectures can be made optional once a more dynamic method for dealing with AddressSanitizer is found. (e.g. always loading PIE into the mmap region for marked binaries.) Link: http://lkml.kernel.org/r/20170807201542.GA21271@beast Fixes: eab0953 ("binfmt_elf: use ELF_ET_DYN_BASE only for PIE") Fixes: 0244599 ("arm64: move ELF_ET_DYN_BASE to 4GB / 4MB") Signed-off-by: Kees Cook <keescook@chromium.org> Reported-by: Kostya Serebryany <kcc@google.com> Acked-by: Will Deacon <will.deacon@arm.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: "H. Peter Anvin" <hpa@zytor.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 704b862 commit c715b72

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

arch/arm64/include/asm/elf.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -114,10 +114,10 @@
114114

115115
/*
116116
* This is the base location for PIE (ET_DYN with INTERP) loads. On
117-
* 64-bit, this is raised to 4GB to leave the entire 32-bit address
117+
* 64-bit, this is above 4GB to leave the entire 32-bit address
118118
* space open for things that want to use the area for 32-bit pointers.
119119
*/
120-
#define ELF_ET_DYN_BASE 0x100000000UL
120+
#define ELF_ET_DYN_BASE (2 * TASK_SIZE_64 / 3)
121121

122122
#ifndef __ASSEMBLY__
123123

arch/x86/include/asm/elf.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -247,11 +247,11 @@ extern int force_personality32;
247247

248248
/*
249249
* This is the base location for PIE (ET_DYN with INTERP) loads. On
250-
* 64-bit, this is raised to 4GB to leave the entire 32-bit address
250+
* 64-bit, this is above 4GB to leave the entire 32-bit address
251251
* space open for things that want to use the area for 32-bit pointers.
252252
*/
253253
#define ELF_ET_DYN_BASE (mmap_is_ia32() ? 0x000400000UL : \
254-
0x100000000UL)
254+
(TASK_SIZE / 3 * 2))
255255

256256
/* This yields a mask that user programs can use to figure out what
257257
instruction set this CPU supports. This could be done in user space,

0 commit comments

Comments
 (0)