Merge pull request #70 from libp2p/fix/err-handling

raulk · web-flow · commit ab02c26ae98b · 2019-04-16T22:16:09.000+01:00
fix error handling in UpdateAddrs: return on error
diff --git a/pstoreds/addr_book.go b/pstoreds/addr_book.go
@@ -264,6 +264,7 @@ func (ab *dsAddrBook) UpdateAddrs(p peer.ID, oldTTL time.Duration, newTTL time.D
 	pr, err := ab.loadRecord(p, true, false)
 	if err != nil {
 		log.Errorf("failed to update ttls for peer %s: %s\n", p.Pretty(), err)
+		return
 	}
 
 	pr.Lock()

Original file line number	Diff line number	Diff line change
`@@ -264,6 +264,7 @@ func (ab *dsAddrBook) UpdateAddrs(p peer.ID, oldTTL time.Duration, newTTL time.D`
`264`	`264`	`pr, err := ab.loadRecord(p, true, false)`
`265`	`265`	`if err != nil {`
`266`	`266`	`log.Errorf("failed to update ttls for peer %s: %s\n", p.Pretty(), err)`
	`267`	`+ return`
`267`	`268`	`}`
`268`	`269`
`269`	`270`	`pr.Lock()`