Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight refactor of auto-relay interfaces #471

Closed
ghost opened this issue Nov 5, 2018 · 1 comment
Closed

Slight refactor of auto-relay interfaces #471

ghost opened this issue Nov 5, 2018 · 1 comment
Assignees

Comments

@ghost
Copy link

ghost commented Nov 5, 2018

Following some synchronous discussion in the libp2p bi-weekly meeting today, resolved:

  • autorelay #454 is good to merge 🍾
  • Ideally, interfaces that may change should be marked as unstable in that PR
  • @vyzo, @Stebalien and @bigs should immediately figure out how to refactor interfaces before users start relying on them. Two main areas:
    • push identify method
    • revise the identify service to push new addresses

I'll let you all discuss these matters here. Marking as high priority so that it does not get forgotten. 😀

@ghost ghost assigned vyzo, bigs and Stebalien Nov 5, 2018
@raulk
Copy link
Member

raulk commented Nov 5, 2018

Closing as this is a duplicate of #472 – the latter of which is tagged and all.

@raulk raulk closed this as completed Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants