Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Thorough Autorelay Tests #528

Open
ZenGround0 opened this issue Feb 1, 2019 · 2 comments
Open

More Thorough Autorelay Tests #528

ZenGround0 opened this issue Feb 1, 2019 · 2 comments
Labels
need/analysis Needs further analysis before proceeding need/review Needs a review topic/filecoin Topic filecoin

Comments

@ZenGround0
Copy link

The filecoin project uses the autorelay and autoNAT features and is aware that it is not trivial to set up tests for these things. The existing autorelay test is reassuring to have. To further improve confidence in the reliability of this feature we would love enhancements to the current autorelay tests. This includes deflaking as well as adding more extensive tests of the features, ideally tests using more realistic networks with less mocking.

cc @phritz -- call out anything I'm missing.

@ZenGround0 ZenGround0 added need/review Needs a review need/analysis Needs further analysis before proceeding topic/filecoin Topic filecoin labels Feb 1, 2019
@Stebalien
Copy link
Member

See the comments starting at ipfs/kubo#5785 (comment) for some discussion on this topic.

@ghost
Copy link

ghost commented Oct 1, 2019

@ZenGround0 Could you verify that this is still a P1 priority for Filecoin? Does it block the launch of testnet or mainnet?

For background: we ran ~16 autorelay servers for IPFS for several months earlier this year. They performed well in the wild. Their bandwidth bills unfortunately proved to be astronomically high, and even after soliciting competitive bids from different hosting companies, we were ultimately forced to all but abandon the project (we have scaled back to either 4 or 2 servers only today). The current focus is on eliminating most of the work relay nodes must do by immediately upgrading relayed connections to direct p2p connections and then removing ourselves from the whole data transfer picture.

We could ask @vyzo to pause his work on that direct connection stuff and build more tests, but my gut feeling is that it's not really what Filecoin wants. Although AutoRelay will be better tested, it will still be too expensive to offer broadly. My recommendation is we try to get a working, well-tested direct connection upgrade version of relay by December 11, and fall back to classic relay nodes only if we fail to hit that date. @vyzo wdyt? @ZenGround0 wdyt? @Stebalien any wisdom here?

@ghost ghost added this to the go-filecoin Testnet milestone Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/analysis Needs further analysis before proceeding need/review Needs a review topic/filecoin Topic filecoin
Projects
None yet
Development

No branches or pull requests

2 participants