Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify should _replace_ addresses #579

Closed
Stebalien opened this issue Apr 5, 2019 · 4 comments · Fixed by #599
Closed

Identify should _replace_ addresses #579

Stebalien opened this issue Apr 5, 2019 · 4 comments · Fixed by #599
Assignees

Comments

@Stebalien
Copy link
Member

Currently, we add all addresses a peer tells us about using identify. Really, we should replace the addresses we know for the peer as we likely have out-of-date information.

May relate to: #575

@vyzo
Copy link
Contributor

vyzo commented Apr 6, 2019

Yes, we need to stop being additive and trust the peer itself.

@Stebalien
Copy link
Member Author

So, this also appears to be affecting autorelay. With autorelay, we push new addresses after we pick a relay. Unfortunately, this means our peers will continue to show both addresses instead of replacing the old ones.

This also explains why we're seeing peers advertising both types of addresses.

@vyzo vyzo self-assigned this Apr 13, 2019
@vyzo
Copy link
Contributor

vyzo commented Apr 15, 2019

So this should be straightforward, we can simply do SetAddrs in identify instead of AddAddrs.

@ghost ghost added the status/in-progress In progress label Apr 15, 2019
@vyzo
Copy link
Contributor

vyzo commented Apr 15, 2019

Implemented in #599.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants