-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identify should _replace_ addresses #579
Comments
Yes, we need to stop being additive and trust the peer itself. |
So, this also appears to be affecting autorelay. With autorelay, we push new addresses after we pick a relay. Unfortunately, this means our peers will continue to show both addresses instead of replacing the old ones. This also explains why we're seeing peers advertising both types of addresses. |
So this should be straightforward, we can simply do |
Implemented in #599. |
Currently, we add all addresses a peer tells us about using identify. Really, we should replace the addresses we know for the peer as we likely have out-of-date information.
May relate to: #575
The text was updated successfully, but these errors were encountered: