Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BOLT 2 : SHOULD fail an HTLC which has timed out. #215

Closed
ariard opened this issue Oct 20, 2018 · 2 comments
Closed

BOLT 2 : SHOULD fail an HTLC which has timed out. #215

ariard opened this issue Oct 20, 2018 · 2 comments

Comments

@ariard
Copy link

ariard commented Oct 20, 2018

While reviewing, I had a doubt, where do we implement initiation of our own of removing timeout incoming HTLCs ? Seems not to be present in any block_connected callbacks right ?
@TheBlueMatt
Copy link
Collaborator

TheBlueMatt commented Oct 23, 2018 •
edited
Loading

Indeed, not yet implemented anywhere. We should also time out pending holding cell HTLCs which we want to add to a channel but fail as we're AwaitingRemoteRAA.

@SWvheerden SWvheerden mentioned this issue Nov 6, 2018
Closed
26 tasks
@TheBlueMatt TheBlueMatt mentioned this issue Nov 15, 2018
Closed
@TheBlueMatt
Copy link
Collaborator

This is basically addressed by #441. Its true that we still may not fail a timed-out htlc when the outbound forwarded leg hasn't yet resolved on-chain, but I think that is the correct behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheBlueMatt @ariard