Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: Measure allocator differences in Rust 1.32 #2309

Closed
olix0r opened this issue Feb 16, 2019 · 3 comments
Closed

proxy: Measure allocator differences in Rust 1.32 #2309

olix0r opened this issue Feb 16, 2019 · 3 comments

Comments

@olix0r
Copy link
Member

olix0r commented Feb 16, 2019

There are reports that rust 1.32 introduced a substantial memory allocation change by adopting jemalloc. We should compare builds of the proxy between 1.31 and 1.32 and measure the impact of the change on our base case, at least.

@hawkw
Copy link
Contributor

hawkw commented Feb 18, 2019

AFAICT based on the linked issue above, it looks like the performance issues in 1.32 may be caused not by the use of jemalloc in general, but by a bug in the specific way jemalloc is linked or exposed to Rust. So, if we find that we're affected by these issues, we may want to consider re-assessing jemalloc later if/when the performance issues on 1.32 are resolved.

@mati865
Copy link

mati865 commented Feb 25, 2019

Rust 1.32 switched to system allocator (glibc on Linux) from jemalloc for produced executables. On recent systems (glibc 2.26+ IIRC) it improves performance and reduces memory usage for most of the typical cases. You can return to jemalloc with this crate: https://crates.io/crates/jemallocator

@olix0r olix0r changed the title proxy: Consider pinning to rust 1.31 proxy: Measure allocator differences in Rust 1.32 Feb 25, 2019
@AdaephonBen
Copy link

@hawkw I'm a newbie to linkerd and I'd like to work on this issue. I noticed that the issue was created a long time ago and version 1.46 is now the latest version of Rust. Is this issue still relevant?

@olix0r olix0r closed this as completed Feb 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants