Skip to content

Commit 5242fbd

Browse files
committed
Add USan+ASan and UBSan+TSan tests to shadow-memory lit parallelism group.
Summary: Previously we were running these tests without the "shadow-memory" lit parallelism group even though we run the ASan and TSan tests in this group to avoid problems with many processes using shadow memory in parallel. On my local machine the UBSan+TSan tests would previously timeout if I set a 30 second per test limit. With this change I no longer see individual test timeouts. This change was made in response to the greendragon build bot reporting individual test timeouts for these tests. Given that the UBSan+ASan and UBSan+TSan tests did not have a parallelism group previously it's likely that some other change has caused the performance degradation. However I haven't been able to track down the cause so until we do, this change seems reasonable and is in line with what we already do with ASan and TSan tests. rdar://problem/51754620 Reviewers: yln, kubamracek, vsk, samsonov Subscribers: #sanitizers, llvm-commits Tags: #sanitizers, #llvm Differential Revision: https://reviews.llvm.org/D63797 llvm-svn: 364366
1 parent 628f36f commit 5242fbd

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

compiler-rt/test/ubsan/lit.common.cfg

+4
Original file line numberDiff line numberDiff line change
@@ -74,3 +74,7 @@ if config.host_os not in ['Linux', 'Darwin', 'FreeBSD', 'Windows', 'NetBSD', 'Su
7474
config.available_features.add('arch=' + config.target_arch)
7575

7676
config.excludes = ['Inputs']
77+
78+
if "ubsan-asan" in config.available_features or "ubsan-tsan" in config.available_features:
79+
if not config.parallelism_group:
80+
config.parallelism_group = 'shadow-memory'

0 commit comments

Comments
 (0)