Skip to content

Commit 23c8dcd

Browse files
committed
Allow flycheck process to exit gracefully
Assuming it isn't cancelled. Closes rust-lang#17902. The only place CommandHandle::join is used is when the flycheck command finishes, so this commit changes the behavior of the method itself.
1 parent a594a2d commit 23c8dcd

File tree

1 file changed

+0
-1
lines changed
  • src/tools/rust-analyzer/crates/rust-analyzer/src

1 file changed

+0
-1
lines changed

src/tools/rust-analyzer/crates/rust-analyzer/src/command.rs

-1
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,6 @@ impl<T: ParseFromLine> CommandHandle<T> {
148148
}
149149

150150
pub(crate) fn join(mut self) -> io::Result<()> {
151-
let _ = self.child.0.kill();
152151
let exit_status = self.child.0.wait()?;
153152
let (read_at_least_one_message, error) = self.thread.join()?;
154153
if read_at_least_one_message || exit_status.success() {

0 commit comments

Comments
 (0)