You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At this point we do have a concept of trigger threshold, but most likely we are not doing the right thing when an event should not actually cause a trigger.
In readout.py all the read() functions should handle the condition where a given event is not causing a trigger.
The text was updated successfully, but these errors were encountered:
This might be not trivial, as the event loop, in the current implementation, looks like
for mc_event in tqdm(photon_list):
x, y = mc_event.propagate(sensor.trans_diffusion_sigma)
digi_event = readout.read(mc_event.timestamp, x, y, *readout_args)
output_file.add_row(digi_event, mc_event)
i.e., we pre-compile a list of mc events, and then we process them, under the assumption that they all trigger.
We have two choices
accept that the numevents command-line switch is the number of generated (as opposed to triggered) events;
bring the MC generation into the event loop and go for a while on the trigger_id.
I vote for the second, provided that we do not incur into a too high of a performance hit.
At this point we do have a concept of trigger threshold, but most likely we are not doing the right thing when an event should not actually cause a trigger.
In readout.py all the read() functions should handle the condition where a given event is not causing a trigger.
The text was updated successfully, but these errors were encountered: